Skip to content

TRT calibration transforms - updates

Sergi Rodriguez Bosca requested to merge serodrig/athena:29jul2024 into 24.0

This MR has four modifications included. Splitting the old TRTCalibtf.py in different files (TRTCalib_accu_tf.py and TRTCalib_calib_tf.py)

  1. Updating TRTcalib ACCU step:

    • We have modified the TRTCalib_accu_tf.py and in order to run athena and generate the final compressed TAR file
    • No need anymore to run the old standalone code under the test_areain the attrtcal account
  2. Updating TRTcalib CALIB step:

    • Still under development. Runs the different TRT detector parts..
    • Still need to put in athena some more .cxx files... ( TRT_StrawStatusReport.C, TRT_StrawStatusReport.cc, TRT_StrawStatus_merge.cc, TRT_StrawMap.h... and probably something else...)
  3. Adding the TRTCalib_merge_tf.py

    • Don't use it at the moment.. first version and not properly implemented for Tier0, since we are not using the corresponding API!!!
  4. Updating TRTCalib_bhadd.cxx

    • It had a problem when changing pointers to standard vector. Missed passing it by reference. Solve now

FYI @hansenph, @nairz

If by any chance someone knows how to retrieve the dsn from the ArgJSON argument using the parseArgs in the Skeleton.py, please comment it below! appreciated!

This changes needs to be in Athena in order to be tested (by others as well)

Merge request reports