This is a followup on !73321 (merged). Changes:
-
Use a std::set
property to translate from a pythonset
-
Use [std::vector::assign
std::map::insert
] to transfer thedouble
default decorator values tofloat
. Right now there's a loop that several people commented on (all agreeing that this wasn't a major point), but we could just avoid the loop completely. -
Come up with better default values for GN2v01
. I just said "light jet" but I vaguely recall that we should probably call it a tau. Best would be to get exactly the values that GN2 uses and therefore not even change outputs at all. -
Rename the flag to enable this (probably need some discussion on what we'd call it) and possibly change the type. -
rename conditions
to something else. -
move the join
function into a common place.
Merge request reports
Activity
This merge request affects 1 package:
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
This merge request affects 3 files:
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/JetTagConditionalDecoratorAlg.h
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNNToolifiers.cxx
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/python/FlavorTagNNConfig.py
added 24.0 Analysis BTagging JetEtmiss analysis-review-required labels
CI Result SUCCESS (hash 62c8948e) Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13871] (remote access info) added 2 commits
added bugfix label
This merge request affects 4 packages:
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
- PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
- PhysicsAnalysis/JetTagging/JetTagConfig
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @sutt ,@svanstro ,@suyogs ,@sekula ,@lbeemste ,@bdong ,@dguest ,@lidiaz as watchers
added Derivation Trigger TriggerMenu review-pending-level-1 labels
CI Result SUCCESS (hash 6838e3e6) Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13890] (remote access info) added 16 commits
-
6838e3e6...5fa20bb4 - 12 commits from branch
atlas:24.0
- 2c0964b2 - use a set rather than a vector for thing that doesn't need ordering
- 948ea00c - use insert rather than loop
- 55a95d7c - rename flag
- 121a214b - rename 'conditions'
Toggle commit list-
6838e3e6...5fa20bb4 - 12 commits from branch
This merge request affects 4 packages:
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
- PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
- PhysicsAnalysis/JetTagging/JetTagConfig
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @suyogs ,@dguest ,@sutt ,@bdong ,@sekula ,@lbeemste ,@svanstro ,@lidiaz as watchers