Skip to content
Snippets Groups Projects

AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable

Merged AthenaConfiguration+AthenaPoolCnvSvc+OutputStreamAthenaPool: Add a new flag to mark streams temporary when applicable
amete/athena:main-introduce-temp-streams into main
All threads resolved!
Merged Alaettin Serhan Mete requested to merge amete/athena:main-introduce-temp-streams into main
All threads resolved!

This MR introduces a new CA flag, Output.TemporaryStreams, which holds a list of stream names that are marked by the user as temporary. If a stream is temporary, two things happen:

  • We overwrite the compression settings to 101 (I kept ZLIB for forward/backward compatibility)
  • We do NOT extend the provenance record

Tagging @gemmeren, @mnowak, and @maszyman explicitly for feedback.

Merge request reports

Pipeline #7864014 passed

Stage: external

Pipeline passed for 5a48273a on amete:main-introduce-temp-streams

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 8 months ago (Aug 2, 2024 9:31am UTC)

Merge details

  • Changes merged into main with b2e2850b (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alaettin Serhan Mete added 1 commit

    added 1 commit

    Compare with previous version

  • Tong Li
    Tong Li @lit ·
    Developer

    Looks fine from AR view point, approving

  • Tong Li removed analysis-review-required label

    removed analysis-review-required label

  • Tong Li added analysis-review-approved label

    added analysis-review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • Database/AthenaPOOL/AthenaPoolCnvSvc
    • Database/AthenaPOOL/OutputStreamAthenaPool

    Affected files list will not be printed in this case

    Adding @gemmeren ,@ssnyder ,@mnowak ,@fwinkl ,@maszyman ,@amete as watchers

  • ATLAS Robot added Run3-DataReco-output-changed label

    added Run3-DataReco-output-changed label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 575f500c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13938] (remote access info)

  • Joany Manjarres
    Joany Manjarres @joany ·
    Developer

    The Athena tests are failing and there seems to be a change in the Output, was this intended? Will you update the references? -L1

  • Joany Manjarres removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joany Manjarres added review-user-action-required label

    added review-user-action-required label

  • Alaettin Serhan Mete added 1 commit

    added 1 commit

    • 5a48273a - Update the comment to cover all cases

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaConfiguration
    • Database/AthenaPOOL/AthenaPoolCnvSvc
    • Database/AthenaPOOL/OutputStreamAthenaPool

    Affected files list will not be printed in this case

    Adding @amete ,@gemmeren ,@ssnyder ,@fwinkl ,@maszyman ,@mnowak as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Peter Van Gemmeren resolved all threads

    resolved all threads

  • Alaettin Serhan Mete removed Run3-DataReco-output-changed label

    removed Run3-DataReco-output-changed label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5a48273a)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 13992] (remote access info)

  • Joany Manjarres removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Joany Manjarres added review-approved label

    added review-approved label

  • Joany Manjarres
    Joany Manjarres @joany ·
    Developer

    All OK now - L1

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit b2e2850b

    mentioned in commit b2e2850b

  • Martina Javurkova mentioned in merge request !75958 (merged)

    mentioned in merge request !75958 (merged)

  • Alaettin Serhan Mete mentioned in merge request !77317 (merged)

    mentioned in merge request !77317 (merged)

  • Adam Edward Barton mentioned in commit amete/athena@be2cdeae

    mentioned in commit amete/athena@be2cdeae

  • Alaettin Serhan Mete mentioned in merge request !77412 (merged)

    mentioned in merge request !77412 (merged)

  • Alaettin Serhan Mete mentioned in commit 2550474a

    mentioned in commit 2550474a

    • Please register or sign in to reply