Skip to content

FPGATrackSim: fix rejection of single FPGATrack events

Ioannis Maznas requested to merge imaznas/athena:FPGATrackSimPrototrackFitter into main

This MR just removes the if (tracks.size()>1) check.

I don't really know why this was there in the first place but it throws events where we had only one FPGA track.

After this fix the reconstruction efficiency slightly increased.

Summary table after fix Hit efficiency : contributing hits over all hits of best matching truth particle |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | eta \ pt | 0-1000 | 1000-2500 | 2500-5000 | 5000-10000 | 10000-100000 | 100000-+inf | All pt | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | 0.0- 0.5 | 0 | 0.762 | 0.902 | 0.928 | 0.903 | 0.915 | 0.821 | | 0.5- 1.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.0- 1.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.5- 2.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.0- 2.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.5- 3.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.0- 3.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.5-+inf | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | All eta | 0 | 0.762 | 0.902 | 0.928 | 0.903 | 0.915 | 0.821 | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| Hit purity : contributing hits of best matching truth particle over all hits on track |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | eta \ pt | 0-1000 | 1000-2500 | 2500-5000 | 5000-10000 | 10000-100000 | 100000-+inf | All pt | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | 0.0- 0.5 | 0 | 0.996 | 0.995 | 1 | 0.998 | 1 | 0.996 | | 0.5- 1.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.0- 1.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.5- 2.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.0- 2.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.5- 3.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.0- 3.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.5-+inf | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | All eta | 0 | 0.996 | 0.995 | 1 | 0.998 | 1 | 0.996 | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| Match probability : weighted common hit sum of best matching truth particle over total track weighted hit sum |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | eta \ pt | 0-1000 | 1000-2500 | 2500-5000 | 5000-10000 | 10000-100000 | 100000-+inf | All pt | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | 0.0- 0.5 | 0 | 0.999 | 0.999 | 1 | 1 | 1 | 0.999 | | 0.5- 1.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.0- 1.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.5- 2.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.0- 2.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.5- 3.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.0- 3.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.5-+inf | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | All eta | 0 | 0.999 | 0.999 | 1 | 1 | 1 | 0.999 | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| Reco efficiency : tracks with assoc. truth particle over all selected truth particles with assoc. measurements. |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | eta \ pt | 0-1000 | 1000-2500 | 2500-5000 | 5000-10000 | 10000-100000 | 100000-+inf | All pt | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| | 0.0- 0.5 | 0 | 0.96 | 0.973 | 1 | 0.981 | 1 | 0.968 | | 0.5- 1.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.0- 1.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 1.5- 2.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.0- 2.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 2.5- 3.0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.0- 3.5 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | 3.5-+inf | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | All eta | 0 | 0.96 | 0.973 | 1 | 0.981 | 1 | 0.968 | |-----------|--------------|--------------|--------------|--------------|--------------|--------------|--------------| |-------------------------------------------------------|--------------| | Number of tracks | 518 | | Number of truth particles with hit counts | 535 | | Associated truth particles without hit counts | 0 | | Tracks without associated truth particle | 0 | | Tracks without selected, associated truth particle | 0 | | Best truth particle without noise correction mismatch | 0 | |-------------------------------------------------------|--------------|

The remaining (17) cases without reconstructed tracks are events with no FPGATracks.

cc @jahreda @tbold @sabidi @piazza

Merge request reports