Skip to content
Snippets Groups Projects

AFT-726: Enable defaults for ftag GNN in the trigger

Merged AFT-726: Enable defaults for ftag GNN in the trigger
dguest/athena:trigdef into 24.0
All threads resolved!
Merged Dan Guest requested to merge dguest/athena:trigdef into 24.0
All threads resolved!

This is an extension of !73628 (merged), where I enable the same feature in the trigger and add default values specific to trigger taggers.

This causes one change in trigger outputs which should have no effect on the trigger counts: since I added a non-zero default value for many of the GNN outputs, the previous default values (which were added in cases where no tracking was run) have changed. These jets were vetoed in the trigger hypo anyway though, so it should change nothing.

Edited by Dan Guest

Merge request reports

Pipeline #7985352 passed

Stage: external

Pipeline passed for 8f5b11aa on dguest:trigdef

Approval is optional

Merged by Stefanie MorgensternStefanie Morgenstern 7 months ago (Aug 26, 2024 11:46am UTC)

Merge details

  • Changes merged into 24.0 with 6be0b17e (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 839d9880)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14444] (remote access info)

  • Dan Guest added 1 commit

    added 1 commit

    • 0f176cd4 - Add case for GN2X, hope for the best...

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
    • PhysicsAnalysis/JetTagging/JetTagConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @bdong ,@lidiaz ,@sekula ,@suyogs ,@lbeemste ,@sutt ,@dguest ,@svanstro as watchers

  • Dan Guest resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :x: CI Result FAILURE (hash 0f176cd4)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14466] (remote access info)

    • Dan Guest
      Dan Guest @dguest ·
      Author Developer
      Resolved by Dan Guest

      Interesting, so putting in zeros for the no track case makes more events pass the 60 and 70% working points, whereas putting in pqcd = 1.0 makes less events pass the 80 and 90% working points. I guess the old zero track default, which I don't have access to from here, is somewhere between the 70 and 80% working points.

      Maybe a question to @lshi and @boliu what we should be doing in this case: I could try to find the value here (but it doesn't look like it's being saved in the AODs so far as I can tell), or I could just spitball something that behaves the same, or I could set it such that we reject all the zero track jets.

  • P
    Philipp Rincke @princke ·
    Developer

    One thread is still unresolved and trigger counts change due to new tagger. This requires new reference files to pass the CI.

    Cheers, Philipp (L1)

  • Philipp Rincke added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Dan Guest added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
    • PhysicsAnalysis/JetTagging/JetTagConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @sekula ,@suyogs ,@svanstro ,@lidiaz ,@lbeemste ,@bdong ,@sutt ,@dguest as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Dan Guest resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8f5b11aa)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14870] (remote access info)

  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    All threads were resolved and the review's comments followed-up. Approved from L1 side (Fábio)

  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added review-approved label

    added review-approved label

  • Stefanie Morgenstern added review-approved-point1 label

    added review-approved-point1 label

  • Stefanie Morgenstern
    Stefanie Morgenstern @shanisch ·
    Developer

    Hi @ruyuan, @dta could you please have a look? Thanks.

  • Duc Ta added review-approved-tier0 label

    added review-approved-tier0 label

  • Rui Yuan added analysis-review-approved label and removed analysis-review-required label

    added analysis-review-approved label and removed analysis-review-required label

  • R
    Rui Yuan @ruyuan ·
    Developer

    Hi, looks fine from AR side, approved. Best regards.

  • Stefanie Morgenstern mentioned in commit 6be0b17e

    mentioned in commit 6be0b17e

  • Stefanie Morgenstern merged

    merged

  • Walter Lampl mentioned in merge request !73957 (merged)

    mentioned in merge request !73957 (merged)

  • BinBin Dong mentioned in merge request !74085 (merged)

    mentioned in merge request !74085 (merged)

    • Please register or sign in to reply