update TauSmearingTool to check MVA-Calo based TES compatibility
This MR is re-introducing a check for MVA-Calo based TES compatibility performed within the TauSmearingTool.
R21 behavior: if the MVA and the Calo based TES are not compatible, set the pt of the tau using Calo based TES -> this would mean changing the tau pt at run-time which is dangerous and not coherent with the TES workflow
New behavior: keep the compatibility test between MVA and Calo based TES, but NOT change the pt of the tau and instead decorate the tau with a boolean called "TESCompatibility"
that indicates the compatibility check results.
Analyses can decide to use this boolean to cross-check the tau quality within the analysis event selection/phase space and identify potentially problematic taus -> NOTE: this is not meant to be used as analysis cut, but to be reported first to TauCP for further discussion.
To mark the different behavior between R21 and updated setup, the TauSmearinTool property "ApplyMVATESQualityCheck"
is renominated "MVATESQualityCheck"
Studies within TauCP are reported in https://indico.cern.ch/event/1446092/contributions/6088305/attachments/2910742/5106751/Slides_TauCP_20240813.pdf
Merge request reports
Activity
added Analysis Reconstruction Tau analysis-review-required main labels
CI Result SUCCESS (hash a0bd1351)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14478] (remote access info) CI Result SUCCESS (hash a5b08140)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14484] (remote access info)added full-unit-tests label
added review-pending-level-1 label
CI Result SUCCESS (hash 1f681d80)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AnalysisBase: number of compilation errors 0, warnings 1
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14501] (remote access info)Looks good to me and unrelated warnings (!73721 (merged) ), approving -L1
added review-approved label and removed review-pending-level-1 label
added analysis-review-expert label and removed analysis-review-required label
added review-pending-level-1 label and removed review-approved label
CI Result SUCCESS (hash 1f681d80)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14616] (remote access info)added review-approved label and removed review-pending-level-1 label
added analysis-review-approved label and removed analysis-review-expert label
mentioned in commit 9e9a2fc7