Initial version of L0MuonEmulation

The new algorithm to emulate L0MuonRoIs smeared from muon truth information is introduced. This is the initial version of the Emulator - the performance will be evaluated and optimised in future. This algorithm has not yet been introduced to any transform configurations.

The RoI definition of pT resolution in the RoI word has been updated since July, i.e. 0.5 GeV of fixed bin width up to 127 GeV.

for ATDAQPPES-1

changed target branch from main to 24.0

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/Muon/L0MuonEmulation

Affected files list will not be printed in this case

Adding @akraszna ,@tamartin as watchers

added 24.0 EDM Trigger analysis-review-required review-pending-level-1 labels

Shouldn't this target main?

CI Result SUCCESS (hash e6742dec)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14717] (remote access info)

Thanks for this @junpei! Left some comments - Tim

removed review-pending-level-1 label

added review-user-action-required label

Couple of other changes which will be needed when making the algorithm re-entrant.

TruthTrackSmearer::emulateL0MuonTrack will need to be a const method. It cannot internally have just a single m_track given that multiple events might be running L0MuonSmearingAlg concurrently.

Suggest something like

bool emulateL0MuonTrack(const float curv, const float eta, const float phi, L0MuonTrack& otrack) const;

    float qoverPt = part->charge() / part->pt();   // in MeV
    L0MuonTrack otrack;
    if (mySmearer->emulateL0MuonTrack(qoverPt, part->eta(), part->phi(), otrack) == false) {   // smearing here
      ATH_MSG_DEBUG("Killed by the efficiency: q/pt=" << qoverPt * 1000. << " (1/GeV)");
      continue;   // false means the truth muon is killed by the emulated efficiency
    }

Similarly the RNG will have a state, so you might need to switch to using a random seed service here.

added 3 commits

• 0a74d1fb - update the random seed generator to use AthRNGSvc
• e71964cc - applied review comments for the reentrant algorithm
• e7a2e86f - applied MR review comments

Compare with previous version

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/Muon/L0MuonEmulation

Affected files list will not be printed in this case

Adding @tamartin ,@akraszna as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

resolved all threads

removed analysis-review-required label

added analysis-review-approved label

Looks fine from AR view point, approving..

CI Result SUCCESS (hash e7a2e86f)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14958] (remote access info)

CI succeeds and all threads have been resolved. Approving form L1.

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

mentioned in commit a8cfc973

merged

mentioned in merge request !73983 (merged)