Skip to content

NavGraph: Remove Element Link, Maintain consistent ordering

Eunju Moon requested to merge emoon/athena:navgraph-cherry-pick into main

cherry pick of the following merge

( !73718 (merged)) NavGraph: Remove ElementLink, replace with Decision pointer

( !73855 (merged)) NavGraph: Fixed randomly ordered NavGraph nodes

DAOD output in WorkflowTests is different from the reference (current main)

Reason: NavGraphNode is now stored in a vector, instead of a map. Hence the order of the nodes could be different. This ordering is not important in runs ( !73718 (merged) was merged to 24.0 without an issue). But it affects the indices recorded in DAOD output in WorkflowTests.

Close comparison of DAOD ROOT file (Left: This branch, Right: Reference) image The number of total ElementLinks stored in the nodes are identical. However, since nodes are stored in a different order in the ROOT file, the distribution of indices are different.

Traits that are not affected by the ordering of nodes did not change.

  1. Integral over the passed-chains IDs for every nodes image__1<span data-escaped-char><span data-escaped-char><span data-escaped-char><span data-escaped-char>_</span></span></span></span>
  2. Integral of the x-component of the transverse momentum of all physics-object "features" linked by the graph image__2<span data-escaped-char><span data-escaped-char><span data-escaped-char><span data-escaped-char>_</span></span></span></span>
Edited by Eunju Moon

Merge request reports