Introduce new implementation of the EMEC geometry based on standard Geant4 shapes

This MR introduces a new implementation of the EMEC geometry based on standard Geant4 shapes, i.e. G4GenericTrap, by Evgueni Tcherniaev. The code comes with a new GeoModel flag EMECStandard that can be used to activate the new description. By defaut the flag is false, so the EMEC is constructed as usual with the custom solid. In order to activate the new description one would need to use the following preExec: --preExec "flags.GeoModel.EMECStandard=True;"

cc @evc @schaarsc @whopkins @jchapman

This merge request affects 5 packages:

• Control/AthenaConfiguration
• DetectorDescription/GeoModel/AtlasGeoModel
• DetectorDescription/GeoModel/GeoModelInterfaces
• DetectorDescription/GeoModel/GeoModelSvc
• LArCalorimeter/LArGeoModel/LArGeoEndcap

Affected files list will not be printed in this case

Adding @rbianchi ,@fwinkl ,@gemmeren ,@ssnyder ,@pavol ,@jojungge ,@maszyman ,@apsallid as watchers

added 24.0 Core Geometry LAr analysis-review-required full-unit-tests review-pending-level-1 labels

CI Result FAILURE (hash f3def6ff)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14839] (remote access info)

The CI failed for 183 - AthExHive_AthExHiveCond_test_ctest (Timeout) Let's try running the CI again to see if we can resolve it.

And the code looks good from L1 side, but it needs double check from L2

Jenkins please retry a build

added review-pending-level-2 label and removed review-pending-level-1 label

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 5 packages:

• Control/AthenaConfiguration
• DetectorDescription/GeoModel/AtlasGeoModel
• DetectorDescription/GeoModel/GeoModelInterfaces
• DetectorDescription/GeoModel/GeoModelSvc
• LArCalorimeter/LArGeoModel/LArGeoEndcap

Affected files list will not be printed in this case

Adding @rbianchi ,@maszyman ,@apsallid ,@fwinkl ,@gemmeren ,@pavol ,@jojungge ,@ssnyder as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

added review-pending-level-2 label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

CI Result SUCCESS (hash f3def6ff)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14847] (remote access info)

changed the description

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-2 label

added review-approved-tier0 label

mentioned in commit eb3ba30b

merged

mentioned in merge request !73957 (merged)