Skip to content

Disable OR selection flags in NTuple if OR selection is applied to all selections

Oliver Majersky requested to merge omajersk/athena:fix-OR-output-vars into main

Currently, when user configures overlap removal with option addToAllSelections=True, we still store the object_select_or_%SYS% output variables in the NTuple. This leads to a huge duplication in output variables, because in this case all the object selection flags already include the OR decision in them, making this flag redundant.

This desired behavior was in fact default at some point, but it seems to have been possibly overwritten in some other OR-related MR. Strictly-speaking this changes interface, so labeling as such. However under normal circumstances, with this configuration a user should never have to use the OR flag explicitly in their analysis code.

For convenience, the output variables are actually defined but disabled if addToAllSelections=True, so that if users for some non-standard reason insist on storing the OR flags explicitly, it is possible to simply enable them in the output block.

Edited by Oliver Majersky

Merge request reports