Skip to content
Snippets Groups Projects

Small GNTau update

Merged Nadav Michael Tamir requested to merge ntamir/athena:GNTau_newVersion into main
All threads resolved!

Tiny changes for deployment of two new GNTau models along with their score flattening files, inclusion in DAOD_PHYS outputs. Tagging @ademaria, @martindl and @edreyer for starters.

Reference talks about the two new scores:

Edited by Antonio De Maria

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jenkins please retry a build

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
    • Reconstruction/tauRec
    • Reconstruction/tauRecTools

    Affected files list will not be printed in this case

    Adding @emmat ,@adbailey ,@xiaozhon ,@jcatmore ,@goetz ,@martindl as watchers

  • :x: CI Result FAILURE (hash d945d5b7)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Antonio De Maria marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
    • Reconstruction/tauRec
    • Reconstruction/tauRecTools

    Affected files list will not be printed in this case

    Adding @martindl ,@jcatmore ,@emmat ,@xiaozhon ,@adbailey ,@goetz as watchers

  • :x: CI Result FAILURE (hash d945d5b7)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Your change breaks the frozen derivation policy in test mc_PHYS_Run3. ERROR Please make sure you explain the reason for the change and ask relevant experts for approval.

  • Hello @gmarchio , the changes are expected because with this MR we would like to phase-out old (broken) GNN TauID score and replace it with two new scores we would like to deploy for the imminent PHYS production.

  • Antonio De Maria changed the description

    changed the description

  • resolved all threads

  • Jenkins please retry a build

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
    • Reconstruction/tauRec
    • Reconstruction/tauRecTools

    Affected files list will not be printed in this case

    Adding @jcatmore ,@adbailey ,@goetz ,@xiaozhon ,@martindl ,@emmat as watchers

  • :x: CI Result FAILURE (hash d945d5b7)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added 147 commits

    Compare with previous version

  • Johannes Elmsheuser resolved all threads

    resolved all threads

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkTau
    • Reconstruction/tauRec
    • Reconstruction/tauRecTools
    • Tools/WorkflowTestRunner

    Affected files list will not be printed in this case

    Adding @emmat ,@jcatmore ,@pagessin ,@adbailey ,@xiaozhon ,@martindl ,@goetz as watchers

  • added Tools label

  • :white_check_mark: CI Result SUCCESS (hash c4d90f7e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Changes are fine and CI succeeds after updating references. All threads have been resolved, approving for L1.

    -L1

  • mentioned in commit 11b2a55e

  • Antonio De Maria mentioned in merge request !74970 (merged)

    mentioned in merge request !74970 (merged)

  • Jean Yves Beaucamp mentioned in merge request !75591 (merged)

    mentioned in merge request !75591 (merged)

  • Please register or sign in to reply
    Loading