Migrating Cluster truth-matching code from barcodes to unique IDs

This is part of the migration of Athena away from using GenParticle barcodes (removed in HepMC3) as a unique identifier for truth particles to GenParticle::id() instead. This change should not affect the truth matching output.

While making these changes I found a weakness in TruthClusterizationFactory::estimateNumberOfParticles(...) where it could potentially misidentify pile-up truth particles as being in the hard-scatter truth event. I've fixed this in the case that matching to pile-up truth is requested.

Tagging @pclark and @averbyts

This merge request affects 3 packages:

• InnerDetector/InDetRecTools/SiClusterizationTool
• InnerDetector/InDetValidation/InDetSegmentDriftCircleAssValidation
• InnerDetector/InDetValidation/InDetTrackClusterAssValidation

Affected files list will not be printed in this case

Adding @sroe ,@goetz ,@gavrilen as watchers

added ITk InnerDetector main review-pending-level-1 labels

CI Result SUCCESS (hash c0195d4f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes are fine and CI succeeds, approving for L1.

-L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 45c96c16