Modernize the MS vertex finding algorithm

Modernisation changes and clean-up:

• Using smart pointers and references
• Changing to range-based for loops where possible

Using standard ATLAS helper functions:

• MuonIdHelperSvc instead of manual station selection
• xAODP4Helpers and AMG
• Gaudi properties and units

Added functionality:

• Global cartesian position of Tracklets
• Linking Tracklets to vertices
• Hits near the vertex split by layer

Fixes:

• inconsistency in MDT-station - B-field mapping to infer the tracklet momentum
• inconsistency in MDT sector assignment for tracklets

@jojungge, @obrandt, @mireveri

ATLASMCP-257

added 1 commit

• 1723c3af - fix default momentum magnitude for charge 0 tracklets to reproduce the nominal vertex construction

Compare with previous version

added 1 commit

• c57d7f28 - Further modernizations

Compare with previous version

added 1 commit

• 00eaed57 - reduce number of type conversions, float -> double consistently

Compare with previous version

added 1 commit

• dae6d2da - use MuonIdHelperSvc instead of manual station selections

Compare with previous version

changed the description

added 1 commit

• e324993c - clean up header files and comments

Compare with previous version

added 1 commit

• 309570c6 - Use SG::AuxElementDecorator to dress the vertex with hits near vertex split by...

Compare with previous version

changed the description

Jenkins please retry a build

changed the description

resolved all threads

added 9169 commits

• 309570c6...a58f222a - 9156 commits from branch atlas:main
• a58f222a...ed048fd8 - 3 earlier commits
• 9cb7ad30 - introduce constness to routines and range-based reference loops
• 33b9f36e - change TrackParticle constructor to access global tracklet position
• 346d3aad - link tracklet as TrackParticles to the vertex
• d2d608d4 - modernize class definitions
• bbc88af7 - fix default momentum magnitude for charge 0 tracklets to reproduce the nominal vertex construction
• 7647a303 - Further modernizations
• bea4f00d - reduce number of type conversions, float -> double consistently
• f7530220 - use MuonIdHelperSvc instead of manual station selections
• 1cb4ff45 - clean up header files and comments
• e23ba970 - Use SG::AuxElementDecorator to dress the vertex with hits near vertex split by...

Compare with previous version

Jenkins please retry a build

This merge request affects 4 packages:

• MuonSpectrometer/MSVertexReconstruction/MSVertexRecoAlg
• MuonSpectrometer/MSVertexReconstruction/MSVertexToolInterfaces
• MuonSpectrometer/MSVertexReconstruction/MSVertexTools
• MuonSpectrometer/MSVertexReconstruction/MSVertexUtils

Affected files list will not be printed in this case

Adding @goetz ,@jojungge ,@stavrop ,@kluit ,@apsallid ,@pscholer ,@mvozak as watchers

added MuonSpectrometer main labels

added Run2-DataReco-output-changed Run2-MCReco-output-changed Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash e23ba970)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes to the MSonlyTrackletsAux container, causing the RecoRun2Data, RecoRun2MC, RecoRun3Data, and RecoRun3MC test to fail, are expected. These come from small modifications to the tracklet reconstruction and are understood.

Changes are indeed expected.

marked this merge request as ready

This merge request affects 4 packages:

• MuonSpectrometer/MSVertexReconstruction/MSVertexRecoAlg
• MuonSpectrometer/MSVertexReconstruction/MSVertexToolInterfaces
• MuonSpectrometer/MSVertexReconstruction/MSVertexTools
• MuonSpectrometer/MSVertexReconstruction/MSVertexUtils

Affected files list will not be printed in this case

Adding @goetz ,@kluit ,@stavrop ,@jojungge ,@pscholer ,@apsallid ,@mvozak as watchers

added review-pending-level-1 label

CI Result FAILURE (hash e23ba970)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

The code looks like a nice update with the same logic up to fixes. I think failures require RC attention as they are intentional, please let me know if this is the wrong tag to add.