Skip to content
Snippets Groups Projects

FPGATrackSim: Add unique ID in FPGATrackSim objects

Merged Ioannis Maznas requested to merge imaznas/athena:FPGABarcode into main
All threads resolved!

This adds uid as an extra variable in the FPGATrackSim objects (hit, (truth) track) for future use.

Somehow related to EFTRACK-555

@jahreda @tbold @brosser @jchapman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • John Derek Chapman
    • Resolved by Ioannis Maznas

      Changes look good to me - I made two groups of suggestions. One group related to usage of HepMcParticleLink::ExtendedBarCode that I'd missed replacing in !74355 (merged) and another set related to the fact that the values returned by HepMcParticleLink::id() should already be valid, but if your plan was to switch the clients to the new method names first, then switch to using the actual id values, then that's fine by me too.

  • added 1 commit

    Compare with previous version

  • Ioannis Maznas resolved all threads

    resolved all threads

  • Ioannis Maznas resolved all threads

    resolved all threads

  • Ioannis Maznas marked this merge request as ready

    marked this merge request as ready

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 2 packages:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimObjects
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput

    Affected files list will not be printed in this case

  • :white_check_mark: CI Result SUCCESS (hash 79a9e6c3)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Changes are fine, CI succeeds and all threads have been resolved. Approving for L1.

    -L1

  • mentioned in commit adec6d89

  • Please register or sign in to reply
    Loading