Reconstruction: Migrating more code away from barcodes

This merge request is part of the preparation for migrating Athena away from using GenParticle barcodes (removed in HepMC3) as a unique identifier for truth particles to GenParticle::id() instead.

Classes which do not use xAOD::Truth are migrated away from barcodes, others are commented marking where things need to change.

This merge request affects 5 packages:

• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/PFlow/PFlowUtils
• Reconstruction/ParticleTruth
• Reconstruction/VKalVrt/VrtSecInclusive
• Reconstruction/eflowRec

Affected files list will not be printed in this case

Adding @pscholer ,@rosati ,@hoide ,@spagan ,@goetz ,@stavrop ,@mhodgkin ,@jburzyns ,@apsallid ,@cohm ,@jojungge ,@dtrischu ,@kluit ,@cantel as watchers

added JetEtmiss Reconstruction analysis-review-required main review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash f347bdec)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 2, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/src/PFSimulateTruthShowerTool.cxx: In member function 'void PFSimulateTruthShowerTool::simulateShower(eflowCaloObject&) const':

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/src/PFSimulateTruthShowerTool.cxx:61:116: error: cannot bind non-const lvalue reference of type 'double&' to a value of type 'int'

61 | for (auto thisCalibHit : *tileActiveCaloCalibrationHitReadHandle) this->fillMap(identifierToTruthEnergyMap,barcode,*thisCalibHit); // FIXME barcode-based | ^~~~~~~ In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/src/PFSimulateTruthShowerTool.cxx:4: /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/eflowRec/PFSimulateTruthShowerTool.h:37:83: note: initializing argument 2 of 'void PFSimulateTruthShowerTool::fillMap(std::map<Identifier, double>&, double&, const CaloCalibrationHit&) const' 37 | void fillMap(std::map<Identifier,double>& identifierToTruthEnergyMap, double& barcode, const CaloCalibrationHit& thisCalibHit) const; // FIXME barcode-based | ~~~~~~~~^~~~~~~ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/src/PFSimulateTruthShowerTool.cxx:62:115: error: cannot bind non-const lvalue reference of type 'double&' to a value of type 'int' 62 | for (auto thisCalibHit : *lArActiveCaloCalibrationHitReadHandle) this->fillMap(identifierToTruthEnergyMap,barcode,*thisCalibHit); // FIXME barcode-based | ^~~~~~~ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Reconstruction/eflowRec/eflowRec/PFSimulateTruthShowerTool.h:37:83: note: initializing argument 2 of 'void PFSimulateTruthShowerTool::fillMap(std::map<Identifier, double>&, double&, const CaloCalibrationHit&) const' 37 | void fillMap(std::map<Identifier,double>& identifierToTruthEnergyMap, double& barcode, const CaloCalibrationHit& thisCalibHit) const; // FIXME barcode-based | ~~~~~~~~^~~~~~~

marked this merge request as draft

removed analysis-review-required label

removed review-pending-level-1 label

resolved all threads

added 1 commit

• 4f6c7bf9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

Jenkins please retry a build

This merge request affects 5 packages:

• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/PFlow/PFlowUtils
• Reconstruction/ParticleTruth
• Reconstruction/VKalVrt/VrtSecInclusive
• Reconstruction/eflowRec

Affected files list will not be printed in this case

Adding @pscholer ,@apsallid ,@goetz ,@rosati ,@cohm ,@spagan ,@mhodgkin ,@dtrischu ,@cantel ,@kluit ,@stavrop ,@jojungge ,@jburzyns ,@hoide as watchers

added analysis-review-required label

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 4f6c7bf9)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• b86fd2b0 - Reconstruction: Migrating more code away from barcodes

Compare with previous version

Jenkins please retry a build

This merge request affects 5 packages:

• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/PFlow/PFlowUtils
• Reconstruction/ParticleTruth
• Reconstruction/VKalVrt/VrtSecInclusive
• Reconstruction/eflowRec

Affected files list will not be printed in this case

Adding @mhodgkin ,@stavrop ,@rosati ,@cantel ,@hoide ,@dtrischu ,@jburzyns ,@spagan ,@goetz ,@jojungge ,@cohm ,@kluit ,@pscholer ,@apsallid as watchers

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash b86fd2b0)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 34ed51d6 - Reconstruction: Migrating more code away from barcodes

Compare with previous version

marked this merge request as ready

This merge request affects 5 packages:

• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/PFlow/PFlowUtils
• Reconstruction/ParticleTruth
• Reconstruction/VKalVrt/VrtSecInclusive
• Reconstruction/eflowRec

Affected files list will not be printed in this case

Adding @goetz ,@mhodgkin ,@spagan ,@rosati ,@hoide ,@dtrischu ,@cantel ,@stavrop ,@pscholer ,@apsallid ,@jburzyns ,@kluit ,@cohm ,@jojungge as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 34ed51d6)

	Athena	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

MR does not concern analysis packages to approving from AR side

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

Changes are fine and CI succeeds, approving for L1.

-L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 08bec8b9

@jchapman could this MR be responsible for the new ctest failure that appeared in the latest Athena,main nightly in the TrackParticleTruthAthenaPoolTest test: https://atlas-sw-build-logs.web.cern.ch/nightlywww/DEVELOPMENTWebArea/ardoc_web_areamain64BE9G13AthenaOpt/ARDOC_TestLog_2024-09-26T2101/Reconstruction_TrackParticleTruthAthenaPool___TrackParticleTruthAthenaPoolConf__TrackParticleTruthAthenaPoolTest__m.html and also in the recent full-unit-test CI pipelines ?

mentioned in merge request !74590 (merged)

Sorry - yes - fix in !74590 (merged)

resolved all threads