StoreGateSvc: cleanup service retrievals

Use ServiceHandle and SmartIF instead of bare service pointers, which will be deprecated in Gaudi v39r1. Also simplify JobOptionsSvc retrieval.

The reference updates are needed because service retrieval is done "quietly" by the handle.

added full-unit-tests label

This merge request affects 3 packages:

• AtlasTest/ControlTest
• Control/StoreGate
• Trigger/TrigEvent/TrigNavigation

Affected files list will not be printed in this case

Adding @ssnyder as watcher

added Core Test Trigger main review-pending-level-1 labels

CI Result FAILURE (hash bc14450b)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

removed review-pending-level-1 label

added review-user-action-required label

Jenkins please retry a build

This merge request affects 3 packages:

• AtlasTest/ControlTest
• Control/StoreGate
• Trigger/TrigEvent/TrigNavigation

Affected files list will not be printed in this case

Adding @ssnyder as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash bc14450b)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

resolved all threads

Changes are fine and CI succeeds, approving for L1.

-L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 44a48f80

merged