Use event number from EventContext in G4Event (ATLASSIM-6635)
This is part of the work for ATLASSIM-6635. Previously Athena had ignored the G4Event eventID (just setting it to 1 everywhere), but this causes issues for Celeritas/AdePT, which use this eventID to follow multiple events in flight on the GPU. This merge request passes the EventContext from the top-level algorithms down to the method where the G4Event is created (ISF::InputConverter::ISF_to_G4Event(...)
), so that it can be used to set the G4Event eventID uniquely for each event in the job.
Other clients of the affected interfaces also need to be updated, mostly they just ignore the new method arguments for now though.
Merge request reports
Activity
added Simulation main labels
mentioned in issue bmorgan/atlassim-6635#1 (closed)
CI Result FAILURE (hash 940307c6)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)added 2 commits
This merge request affects 8 packages:
- Simulation/G4Atlas/G4AtlasAlg
- Simulation/ISF/ISF_Acts/ISF_ActsTools
- Simulation/ISF/ISF_Core/ISF_Algorithms
- Simulation/ISF/ISF_Core/ISF_Interfaces
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Core/ISF_Tools
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
- Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
Affected files list will not be printed in this case
Adding @pagessin ,@schaarsc ,@tbold ,@tadej ,@toyamaza ,@jbeirer ,@jchapman ,@zhangr ,@lmijovic ,@jojungge ,@tcuhadar ,@cvarni as watchers
added ACTS label
CI Result FAILURE (hash 75ec020c)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 3
AthSimulation: number of compilation errors 3, warnings 2
For experts only: Jenkins output (remote access info)This merge request affects 10 packages:
- Simulation/G4Atlas/G4AtlasAlg
- Simulation/ISF/ISF_Acts/ISF_ActsTools
- Simulation/ISF/ISF_Core/ISF_Algorithms
- Simulation/ISF/ISF_Core/ISF_Interfaces
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Core/ISF_Tools
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
- Simulation/ISF/ISF_Fatras/ISF_FatrasServices
- Simulation/ISF/ISF_Geant4/ISF_Geant4Services
- Simulation/ISF/ISF_Geant4/ISF_Geant4Tools
Affected files list will not be printed in this case
Adding @tbold ,@tadej ,@zhangr ,@jchapman ,@tcuhadar ,@pagessin ,@cvarni ,@toyamaza ,@lmijovic ,@jbeirer ,@schaarsc ,@jojungge as watchers
CI Result FAILURE (hash d536a8d8)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 2
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output (remote access info)