StoreGate: Fix some corner cases in WriteDecorHandle.

If isAvailable() was called on a WriteDecorHandle before a decoration was recorded, then the handle would fail to lock the decoration when it was destroyed. There were also issues if the handle was renounced.

Fixed. Also simplified a bit so that typeless_dataPointer_impl no longer needs to be virtual.

See !73627 (closed) and ATLASRECTS-8008.

This will need to go in r24 as well, but there's a chance this this will break something, so test it in main first. (Some derivation code was found to be relying on this bug...)

This merge request affects 1 package:

• Control/StoreGate

This merge request affects 4 files:

• Control/StoreGate/StoreGate/WriteDecorHandle.h
• Control/StoreGate/StoreGate/WriteDecorHandle.icc
• Control/StoreGate/StoreGate/WriteDecorHandleKey.icc
• Control/StoreGate/test/WriteDecorHandle_test.cxx

Adding @ssnyder as watcher

added Core main review-pending-level-1 labels

added Run2-DataReco-output-changed Run3-DataReco-output-changed labels

CI Result FAILURE (hash 78716e18)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

marked this merge request as draft

removed review-pending-level-1 label

added full-integration-tests full-unit-tests labels

added 1 commit

• 0ae50511 - Further fix for renounced handles

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Control/StoreGate

This merge request affects 4 files:

• Control/StoreGate/StoreGate/WriteDecorHandle.h
• Control/StoreGate/StoreGate/WriteDecorHandle.icc
• Control/StoreGate/StoreGate/WriteDecorHandleKey.icc
• Control/StoreGate/test/WriteDecorHandle_test.cxx

Adding @ssnyder as watcher

CI Result FAILURE (hash 0ae50511)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

removed Run2-DataReco-output-changed label

removed Run3-DataReco-output-changed label

added 1 commit

• f47c6939 - Another try at properly handling renounced handles

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Control/StoreGate

This merge request affects 4 files:

• Control/StoreGate/StoreGate/WriteDecorHandle.h
• Control/StoreGate/StoreGate/WriteDecorHandle.icc
• Control/StoreGate/StoreGate/WriteDecorHandleKey.icc
• Control/StoreGate/test/WriteDecorHandle_test.cxx

Adding @ssnyder as watcher

CI Result FAILURE (hash f47c6939)

	Athena	AthSimulation	AthGeneration	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

I don't think these errors are due to this change, but will try again in a bit...

Jenkins please retry a build