Fix wrong property setting of Argon ToTCorrections in TRT_DriftFunctionTool
The properties ToTCorrectionsBarrelAr
and ToTCorrectionsEndcapAr
were wrongly setting the Xenon properties (the two sets of properties being set to identical values in python). This means on the other hand that the ToT corrections for Argon were left to their default null values.
This MR fixes the wrong property settings in C++ and adjust the python config to keep the output unchanged for now. A possible output changing fix will be discussed separately in https://its.cern.ch/jira/browse/ATLIDTRKCP-632
Merge request reports
Activity
added InnerDetector label
added bugfix label
added 24.0 review-pending-level-1 labels
mentioned in merge request !74726 (merged)
CI Result FAILURE (hash 20e811ac)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)added 1 commit
- d835ddf6 - Fix wrong property setting of Argon ToTCorrections in TRT_DriftFunctionTool
CI Result SUCCESS (hash d835ddf6)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)removed review-pending-level-1 label
added review-approved label
- Resolved by Thomas Strebler
Hi @tstreble, many thanks for spotting the C++ error and fixing that. The python values were intended to be identical for Ar and Xe, so please revert those changes.
added review-approved-tier0 label
mentioned in commit a06101a5
mentioned in merge request !74896 (merged)