BeamPipeGeoModel: service pointer migration
Plus some code cleanup
Merge request reports
Activity
This merge request affects 1 package:
- AtlasGeometryCommon/BeamPipeGeoModel
This merge request affects 4 files:
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory_Lite.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.cxx
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.h
Adding @rbianchi as watcher
added Geometry main review-pending-level-1 labels
CI Result FAILURE (hash 1b2178c7)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)This merge request affects 1 package:
- AtlasGeometryCommon/BeamPipeGeoModel
This merge request affects 5 files:
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory_Lite.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.cxx
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.h
- release_notes.md
Could not map the following files to a domain:
- release_notes.md
Adding @rbianchi as watcher
CI Result SUCCESS (hash 11a79687)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)This merge request affects 1 package:
- AtlasGeometryCommon/BeamPipeGeoModel
This merge request affects 4 files:
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorFactory_Lite.h
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.cxx
- AtlasGeometryCommon/BeamPipeGeoModel/src/BeamPipeDetectorTool.h
Adding @rbianchi as watcher
CI Result SUCCESS (hash 7a3b739d)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)removed review-pending-level-1 label
added review-approved label
mentioned in commit 289d4a5a