Skip to content
Snippets Groups Projects

Draft: Seeder types rebase2 grid fix

Closed Draft: Seeder types rebase2 grid fix
lcalic/athena:seeder-types_rebase2-gridFix into grid-seeder
1 unresolved thread
Closed Lara Calic requested to merge lcalic/athena:seeder-types_rebase2-gridFix into grid-seeder
1 unresolved thread

This MR adds changes/fixes to Grid seeder implementation in Athena.

Updates made to InDetPriVxFinderToolConfig.py (VertexFinderToolCfg returns the ActsGridAdaptiveMultiFindingCfg when the Grid seeder is selected by ActsGridDensity), and ActsPriVxFinderConfig.py (new configuration ActsGridAdaptiveMultiFindingCfg takes care of parameters only specific to the Grid seeder).

Merge request reports

Approval is optional

Closed by Thomas StreblerThomas Strebler 4 months ago (Dec 9, 2024 6:30am UTC)

Merge details

  • The changes were not merged into grid-seeder.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Tracking/Acts/ActsConfig/python/ActsPriVxFinderConfig.py
38 kwargs.setdefault("gridResolutionD0", flags.Tracking.PriVertex.gridResolutionD0)
39 kwargs.setdefault("maxVertices", flags.Tracking.PriVertex.gridMaxVertices)
40 kwargs.setdefault("gridBinSize", 1.0 * Units.mm)
41 else:
42 kwargs.setdefault("seederType", "Gaussian")
34 43
35 44 if flags.GeoModel.Run >= LHCPeriod.Run4:
36 45 kwargs.setdefault("minWeight", 0.02)
37 46 kwargs.setdefault("maxIterations", 200)
38 47
39 acc.setPrivateTools(
40 CompFactory.ActsTrk.AdaptiveMultiPriVtxFinderTool(name, **kwargs))
48 acc.setPrivateTools(CompFactory.ActsTrk.AdaptiveMultiPriVtxFinderTool(name, **kwargs))
41 49 return acc
42 50
43 def TrigActsGaussAdaptiveMultiFindingCfg(flags,
  • Lara Calic added 1 commit

    added 1 commit

    • bc30dec9 - minor changes to grid configuration

    Compare with previous version

  • Lara Calic added 2 commits

    added 2 commits

    • 689ee342 - 1 commit from branch atlas:grid-seeder
    • 98266a1f - Merge branch 'grid-seeder' into 'seeder-types_rebase2-gridFix'

    Compare with previous version

  • Lara Calic added 3 commits

    added 3 commits

    • f9eceb15 - get it to run
    • d1836e69 - Merge branch 'seeder-types_rebase2-gridFix' into 'MG_getItToCompile'
    • 79744155 - Merge branch 'MG_getItToCompile' into 'seeder-types_rebase2-gridFix'

    Compare with previous version

  • Lara Calic added 2293 commits

    added 2293 commits

    • 79744155...c5763de7 - 2283 earlier commits
    • d244218e - FPGATrackSim: Check if clusters share hits before merging
    • f0b95b48 - Merge branch 'FPGATrackSimPixClusteringMergeOverlapping' into 'main'
    • 61bea739 - Small improvements to IdDict
    • 96ea83f8 - Merge branch 'main-cleanup-IdDict' into 'main'
    • 551e5536 - TrigAnalysisTest: ignore count diff in main
    • 6f3073d9 - Merge branch 'main_TrigARTrefmain' into 'main'
    • 7161aab5 - AthContainers: Split dictionaries for faster loading.
    • e775b452 - Merge branch 'splitDict.AthContainers-20241202' into 'main'
    • 6a253ad2 - fix rebased
    • b083e46b - fix in VertexFindingFlags.py

    Compare with previous version

    Toggle commit list
  • Lara Calic added 1 commit

    added 1 commit

    Compare with previous version

  • Thomas Strebler
    Thomas Strebler @tstreble ·
    Developer

    Superseded by !76421 (closed)

  • Thomas Strebler closed

    closed

    • Please register or sign in to reply