Update DAOD_PHYS/LITE test files

Needed for FTAG recommendation updates based on GN2v01

added full-unit-tests label

Will undraft once the files are copied on cvmfs

mentioned in merge request !75212 (merged)

marked this merge request as ready

Jenkins please retry a build

This merge request affects 1 package:

• AsgExternal/Asg_Test

This merge request affects 8 files:

• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt

added analysis-review-required main no-domain review-pending-level-1 labels

CI Result FAILURE (hash bb1d4fdd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added review-user-action-required label and removed review-pending-level-1 label

Hi @tstreble some of the CP alg tests are crashing on the EventSelection part, you can fix them by changing these two lines to read

EL_N 25000 == 1

(i.e. dropping one of them and editing the other)

added 2 commits

• 171625cb - Adjust FullCPAlgorithmsTest config with new inputs
• 67b4e793 - Update xAODDataSource references

Compare with previous version

This merge request affects 3 packages:

• AsgExternal/Asg_Test
• Control/xAODDataSource
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig

Affected files list will not be printed in this case

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt

Adding @krumnack ,@ssnyder ,@akraszna ,@tadej as watchers

added Analysis CPAlgorithms Core review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 67b4e793)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 221da673 - Updated ElectronEfficiencyCorrection ref

Compare with previous version

This merge request affects 4 packages:

• AsgExternal/Asg_Test
• Control/xAODDataSource
• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection

Affected files list will not be printed in this case

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt

Adding @ssnyder ,@tadej ,@akraszna ,@krumnack as watchers

added Egamma label

CI Result SUCCESS (hash 221da673)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added analysis-review-expert label and removed analysis-review-required label

Hi, @krumnack would you please take a look. Best regards

added review-pending-expert label and removed review-pending-level-1 label

added review-pending-level-1 label and removed review-pending-expert label

Code changes should be reviewed by L1 shifter as usual. The analysis review can proceed in parallel.

Looks good for L1 - waiting for analysis-expert

Malte (L1)

Hi @malgren,

You should not wait for analysis review. Just sign off if it looks good to you. The RCs know not to merge until analysis review is done.

Cheers, Nils [Analysis RC]

Hi @tstreble,

From my side this is fine, we should probably update the test files more often than we do. Approving for AR.

One comment, not necessarily for this MR: It would probably be nice if we had more files. We were discussing that maybe a Run 4 file would be good, so that we don't break it again, now that it works. But also the same complement of Run 3 files as for Run 2 would be nice, i.e. data, fullsim, fastsim, both for PHYS and PHYSLITE. That's of course not necessarily on you, but you seem to know how to find and install the right files, and the last time I asked about that, that seemed to be the issue.

Cheers, Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-expert label

Approved by L1 above, so setting the label accordingly

added review-approved label and removed review-pending-level-1 label

mentioned in merge request !75146 (merged)

There are unresolved threads

resolved all threads

resolved all threads

merged

mentioned in commit 4a231a40