Skip to content
Snippets Groups Projects

IDTPM: Adding configurable unlinkedAsFakes option

Merged Marco Aparo requested to merge maparo/athena:maparo-main-IDTPM-fakeUL-v1 into main
All threads resolved!

Adding unlinkedAsFakes trackAnalysis flag to not produce unlinked rate plots, and instead consider truth-unlinked tracks as fakes. The default is true. By setting it to false unlinked and fake rates plots are produced for continuity with the current implementation. This setup is used in the ART test that performs the comparison with IDPVM.

CC @tstreble @ncalace @mvessell @rgarg @piazza

Edited by Marco Aparo

Merge request reports

Pipeline #8417975 passed

Pipeline passed for eebdade4 on maparo:maparo-main-IDTPM-fakeUL-v1

Approval is optional

Merged by Tadej NovakTadej Novak 5 months ago (Nov 4, 2024 9:54am UTC)

Merge details

  • Changes merged into main with 0f62f625 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Aparo added 1 commit

    added 1 commit

    • eebdade4 - Adding comment offlTrkAnaConfig.json

    Compare with previous version

  • Thomas Strebler resolved all threads

    resolved all threads

  • Marco Aparo marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetTrackPerfMon

    This merge request affects 8 files:

    • InnerDetector/InDetValidation/InDetTrackPerfMon/InDetTrackPerfMon/ITrackAnalysisDefinitionSvc.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/data/offlTrkAnaConfig.json
    • InnerDetector/InDetValidation/InDetTrackPerfMon/python/InDetTrackPerfMonConfig.py
    • InnerDetector/InDetValidation/InDetTrackPerfMon/python/InDetTrackPerfMonFlags.py
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/OfflineObjectDecorHelper.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisDefinitionSvc.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx

    Adding @sroe ,@maparo ,@goetz ,@cvarni as watchers

  • :white_check_mark: CI Result SUCCESS (hash eebdade4)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Looks fine to me. However, a lot of if-statments and new returns have been added. L2 should have a quick look to ensure I didn't miss anything.

    Malte (L1)

  • lgtm

  • added review-approved label and removed review-pending-level-2 label

  • merged

  • Tadej Novak mentioned in commit 0f62f625

    mentioned in commit 0f62f625

  • Please register or sign in to reply
    Loading