IDPVM: Tweak definition of unlinked fakes
Using the probability match even with unlinked fakes will help us get the full picture for the MC-based tracking fake rate.
In more details:
Before this MR, 2 TEfficiencies are created:
- N. of Unlinked / N. of tracks
- N. of Linked tracks w/ prob < 0.5 / N. of Linked tracks
This MR changes the first one to
- N. of Unlinked w/ prob < 0.5 / N. of Unlinked
The previous TEfficiency can be recovered, since TEfficiency objects contain both the denominator & numerator histogram. Moreover, this definition is also safe to use even in standard truth sample, since in the code there's a nan check when deciding if a track is fake or not with the probability.
Merge request reports
Activity
added InnerDetector PhysValidation main review-pending-level-1 labels
- Resolved by Frank Winklmeier
@tstreble we'll need a sweep to 24.0 as well?
- Resolved by Louis-Guillaume Gagnon
This MR changes the first one to
- N. of Unlinked w/ prob < 0.5 / N. of Unlinked
I would really avoid anything which doesn't use N. of tracks as denominator.
Edited by Thomas Strebler
CI Result SUCCESS (hash 68439918)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added 1 commit
- 7bf097e5 - Tweak the axis labels of the fake rate tefficiencies to reflect linked or unlinked content
This merge request affects 52 packages:
- .devcontainer
- .vscode
- AsgExternal/Asg_Test
- AtlasGeometryCommon/BeamPipeGeoModel
- AtlasGeometryCommon/CavernInfraGeoModel
- AtlasGeometryCommon/CrackRegionGeoModel
- AtlasGeometryCommon/GeoModelEnvelopes
- AtlasGeometryCommon/SubDetectorEnvelopes
- AtlasTest/CITest
- AtlasTest/ControlTest
- AtlasTest/DatabaseTest/AthenaDBTestRec
- AtlasTest/DatabaseTest/AthenaPoolTest
- AtlasTest/DatabaseTest/AthenaPoolTestData
- AtlasTest/DatabaseTest/IOVDbTestAlg
- AtlasTest/DatabaseTest/IOVDbTestConditions
- AtlasTest/TestTools
- Build
- Calorimeter/CaloCalibHitRec
- Calorimeter/CaloClusterCorrection
- Calorimeter/CaloCnv/CaloAthenaPool
- Calorimeter/CaloCnv/CaloIdCnv
- Calorimeter/CaloCnv/CaloJiveXML
- Calorimeter/CaloCnv/CaloSimEventAthenaPool
- Calorimeter/CaloCnv/CaloSimEventTPCnv
- Calorimeter/CaloCnv/CaloTPCnv
- Calorimeter/CaloCnv/CaloTTDetDescrCnv
- Calorimeter/CaloCondPhysAlgs
- Calorimeter/CaloConditions
- Calorimeter/CaloDetDescr
- Calorimeter/CaloDetDescrUtils
- Calorimeter/CaloDmDetDescr
- Calorimeter/CaloEvent
- Calorimeter/CaloG4Sim
- Calorimeter/CaloGeoHelpers
- Calorimeter/CaloIdentifier
- Calorimeter/CaloInterface
- Calorimeter/CaloLocalHadCalib
- Calorimeter/CaloMonitoring
- Calorimeter/CaloRec
- Calorimeter/CaloRecGPU
- Calorimeter/CaloSimEvent
- Calorimeter/CaloTools
- Calorimeter/CaloTrackingGeometry
- Calorimeter/CaloTriggerTool
- Calorimeter/CaloUtils
- Commission/CommissionEvent
- Commission/CommissionRec
- Control/AthAllocators
- Control/AthAnalysisBaseComps
- Control/AthCUDA/AthCUDACore
- Control/AthCUDA/AthCUDAServices
- Control/AthContainers
Affected files list will not be printed in this case
Could not map the following files to a domain:
- AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
- AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
- AsgExternal/Asg_Test/cmt/TestFileData.txt
- AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
- AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
- .gitignore
- AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
- AsgExternal/Asg_Test/CMakeLists.txt
- AsgExternal/Asg_Test/cmt/TestFileMC.txt
- AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
Adding @ssnyder ,@jchapman ,@fpastore ,@dossantn ,@fwinkl ,@pagessin ,@gemmeren ,@rbianchi ,@akraszna ,@pavol as watchers
added 24.0 Build CUDA Calorimeter Core DQ Geometry Other Simulation Test Trigger analysis-review-required labels
removed main label
removed Build label
removed Calorimeter label
removed Core label
removed DQ label
removed CUDA label
removed Geometry label
removed PhysValidation label