Rework FPGATrackSimRoad class

This design has a lot of implicit shared_ptr counting and object copying which makes me a bit nervous (are we sure it is copying or incrementing when we want it to?)

I try to make things a bit more explicit here

This merge request affects 2 packages:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimObjects

Affected files list will not be printed in this case

added EFTracking Trigger main review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 47bd61e7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 0ca178ad - Rework FPGATrackSimRoad class

Compare with previous version

This merge request affects 4 packages:

• Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimLRT
• Trigger/EFTracking/FPGATrackSim/FPGATrackSimObjects

Affected files list will not be printed in this case

CI Result SUCCESS (hash 0ca178ad)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes are fine and CI succeeds, approving for L1. -L1

added review-approved label and removed review-pending-level-1 label

Thanks Adam, I reported this a while a go and I think long term the goal is to move away from shared pointers.

merged

mentioned in commit 9c014330

mentioned in merge request !75417 (merged)