MultipleStreamManager+CutFlowSvc: delete legacy configuration

After the removal of the legacy CP alg configuration in !75615 (merged) we can now delete a few more legacy configuration modules.

cc @tadej

added Legacy Config Removal full-unit-tests labels

This merge request affects 2 packages:

• Database/AthenaPOOL/OutputStreamAthenaPool
• Event/EventBookkeeperTools

Affected files list will not be printed in this case

Adding @ssnyder ,@maszyman ,@gemmeren ,@mnowak ,@amete ,@tadej as watchers

added Database EDM analysis-review-required main review-pending-level-1 labels

The cutflow removal is tricky. I think we decided not to break 3rd-party analysis code that may still use this as the config is "core-enough". On the other hand I would be happy to remove it. Let's see what others think.

CI Result FAILURE (hash 8f541ced)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Not quite sure how this relates to removing the CP algorithm sequences, but it seems like a good cleanup of the code base. Approving for AR.

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-required label

OK, Nils is happy so I'm also fine with it

Test failures are unrelated.

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 946f0370

Hi @fwinkl @tadej ! Our production framework relies on the machinery removed by this MR. Is it possible to add it back, if it was indeed just removed for general cleanup? Otherwise, do you have an easy replacement for these functions/objects?

Hi @mbasso, as legacy Athena configuration was no longer maintained we considered it is safer to be removed as it would most likely break at some time. With CA configuration the MSM was simply not needed anymore so it was not migrated.

Note that if using AthAnalysis you should also move to ComponentAccumulator as configuration engine. The overall documentation is available here, the output fragment is available here.

Hi Tadej, yes, that makes sense! It is unfortunately a bit of difficult time to migrate to CA, and so far, the legacy JOs still work well for us. For now, I've copied these particular modules to our framework, I suppose I will have to live with the consequences