TruthUtils: Improve SUSY::spin helper function. Add SUSY::spin2 helper function.

• Fixed SUSY::spin to return a double rather than a bool.
• Added SUSY::spin2 function to more easily deal with non-integer spins in testPID. (SUSY::spin now returns 1.0*spin2()/2.0)
• Updated testPID unit test to check SUSY::spin2 rather than SUSY::spin.
• Updated SUSY::spin2() to return the correct values (i.e. 2J) for fundamental SM particles, SM Hadrons, SUSY particles and other BSM particles.
• Kept the output unchanged (i.e. 1) for nuclei - TODO fix this in a follow-up MR.

Currently unused, but, in the future, the primary usage of this function will be in calls to G4ParticleDefinition when defining new particles in Geant4 for SUSY/Exotics simulation. NB Although this function is currently in the SUSY namespace, we plan to simplify the code by dropping this intermediate namespace in a future MR.

changed the description

added 1 commit

• db3e08e8 - AtlasPID: Improve SUSY::spin helper function. Add SUSY::spin2 helper function.

Compare with previous version

changed the description

added 1 commit

• 7f40eb59 - AtlasPID: Improve SUSY::spin helper function. Add SUSY::spin2 helper function.

Compare with previous version

added 1 commit

• 016f4ff3 - AtlasPID: Improve SUSY::spin helper function. Add SUSY::spin2 helper function.

Compare with previous version

changed the description

changed the description

marked this merge request as ready

mentioned in merge request !75683 (merged)

This merge request affects 1 package:

• Generators/TruthUtils

This merge request affects 3 files:

• Generators/TruthUtils/TruthUtils/AtlasPID.h
• Generators/TruthUtils/share/AtlasPIDTest.ref
• Generators/TruthUtils/test/testPIDs.cxx

Adding @zmarshal ,@averbyts as watchers

added Generators analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 016f4ff3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

changed title from AtlasPID: Improve SUSY::spin helper function. Add SUSY::spin2 helper function. to TruthUtils: Improve SUSY::spin helper function. Add SUSY::spin2 helper function.

Approving from L1 side (Fábio).

removed review-pending-level-1 label

added review-approved label

removed analysis-review-required label

added analysis-review-approved label

merged

mentioned in commit db3ce70e