address Coverity defects in FPGATrackSimHough

Mainly performance defects; pass shared_ptr by const ref instead of copy, use const auto & instead of plain auto. One possible out-of-range access trapped early with a more informative message.