Skip to content

CP Algorithms: allow blocks with all-default settings to pass their containerNamer down to the sub-blocks

Baptiste Ravina requested to merge ravinab/athena:default_blocks_yaml into main

I found the following bug in the YAML config of CP blocks:

MyBlock:
  SubBlock:
    subSetting: 'something'

in this case, the SubBlock will not be configured appropriately (e.g. getting containerName from MyBlock). A work-around is to specify at least one option of MyBlock, but this is of course not desirable

MyBlock:
   setting: 'I already have nice defaults!'
   SubBlock:
      subSetting: 'something'

In this MR I propose a fix whereby I give MyBlock a placeholder property, initialise it with its default values, grab its containerName and pass that on to the SubBlock. I'm not a YAML-config expert, so this could be improved upon by @krumnack / @jolamber / @mmaroun.

Merge request reports

Loading