Skip to content
Snippets Groups Projects

AthExHive: introduced AthExHiveConfig.py

Merged Vakhtang Tsulaia requested to merge tsulaia/athena:main-athexhiveconfig into main

Plus minor updates in the HiveAlg* code

This is still a preliminary version of the new AthExHiveConfig.py but early comments are more than welcome.

ATEAM-1043

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 83b52cbe - AthExHive: introduced AthExHiveConfig.py

    Compare with previous version

  • added 1 commit

    • 4f81da92 - AthExHive: introduced AthExHiveConfig.py

    Compare with previous version

  • Vakhtang Tsulaia marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • Control/AthenaExamples/AthExHive

    This merge request affects 25 files:

    • Control/AthenaExamples/AthExHive/python/AthExHiveConfig.py
    • Control/AthenaExamples/AthExHive/src/HiveAlgA.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgA.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgB.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgB.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgBase.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgBase.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgC.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgC.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgD.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgD.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgE.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgE.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgF.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgF.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgG.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgG.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgR.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgR.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgV.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgV.h
    • Control/AthenaExamples/AthExHive/src/HiveExSvc.cxx
    • Control/AthenaExamples/AthExHive/src/HiveExSvc.h
    • Control/AthenaExamples/AthExHive/src/ThreadInitTool.cxx
    • Control/AthenaExamples/AthExHive/src/ThreadInitTool.h

    Adding @ssnyder ,@gemmeren ,@rbianchi ,@maszyman as watchers

  • CI Result SUCCESS (hash 4f81da92)

    Athena AthSimulation AthGeneration AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output (remote access info)

    • Resolved by Vakhtang Tsulaia

      Hi @tsulaia @tadej ,

      so pleased I didn't need to do this myself 😄

      In the old version there were these lines:

      from GaudiHive.GaudiHiveConf import ThreadPoolSvc
      svcMgr += ThreadPoolSvc("ThreadPoolSvc")
      svcMgr.ThreadPoolSvc.ThreadInitTools = ["ThreadInitTool"]

      I can't find an equivalent in the new one... are these now superfluous? I didn't really understand what they were for.

      I assume the various C++ updates are just incidental housekeeping and not directly relevant to CA?

      Anyway, looks good, Tadej should approve when he's happy.

      James.

  • Changes and CI look fine for L1. Passing on to L2 for a second review since I'm not familiar with the code.

    Kira (L1)

  • Vakhtang Tsulaia added 34 commits

    added 34 commits

    Compare with previous version

  • This merge request affects 1 package:

    • Control/AthenaExamples/AthExHive

    This merge request affects 25 files:

    • Control/AthenaExamples/AthExHive/python/AthExHiveConfig.py
    • Control/AthenaExamples/AthExHive/src/HiveAlgA.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgA.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgB.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgB.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgBase.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgBase.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgC.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgC.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgD.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgD.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgE.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgE.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgF.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgF.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgG.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgG.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgR.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgR.h
    • Control/AthenaExamples/AthExHive/src/HiveAlgV.cxx
    • Control/AthenaExamples/AthExHive/src/HiveAlgV.h
    • Control/AthenaExamples/AthExHive/src/HiveExSvc.cxx
    • Control/AthenaExamples/AthExHive/src/HiveExSvc.h
    • Control/AthenaExamples/AthExHive/src/ThreadInitTool.cxx
    • Control/AthenaExamples/AthExHive/src/ThreadInitTool.h

    Adding @maszyman ,@gemmeren ,@rbianchi ,@ssnyder as watchers

  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • Author Developer

    I'm not sure who our L2 is this week. Perhaps @tadej can give this MR his final blessing when he gets a moment.

  • CI Result SUCCESS (hash a0ecd21e)

    Athena AthSimulation AthGeneration AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output (remote access info)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading