Skip to content
Snippets Groups Projects

Setting unique name to empty steps and empty sequences during the Trigger Menu alignment

Merged Francesca Pastore requested to merge fpastore/athena:zeromult into 24.0

Other changes needed to name the empty steps and the empty sequences in a unique way, in order to include more complex chains for Anomaly detection:

  • added createEmptyMenuSequenceCfg function to generate the Empty sequence generators named as the name of the sequence, for easy debugging. This works in the alignment correctly, but when used in custom steps it fails with no reason (succeeds in external unit tests), so this has to be worked out
  • made it more clear the way the empty steps are handled during chain merging: basically each empty step due to be merged with a filled step is transformed into as many empty sequences as the step multiplicity, and the name of each empty sequence is unique and follows the order of the internal legs of the step
  • I added a list of #TODO because I think more simplifications are possible, and will be made in next MRs
  • getEmptySeqName is currently used passing the signature, and not the step name, so I removed the RE for StepX
  • added some cleaning of code to make it more readable

Tagging @khoo , @tamartin and @ksugizak

Edited by Francesca Pastore

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading