TileTPCnv: Save Tile raw channel collection DSP metadata (ATLASSIM-7403)

For every Tile Calorimeter module the so-called Tile DQ status fragment is written in the ByteStream in every event. Information from this fragment is then stored in the metadata for the corresponding Tile raw channel collection. And then the Tile DQ status is produced on the fly using this metadata also.

This information is not saved in the POOL format (it seems to be not needed before). But if the ByteStream for data overlay is pre-converted in the RDO POOL format to augment it, then this information is also needed to produce the correct Tile DQ status.

So, Tile raw channel container converter has been modified to save also the raw channel collection metadata. This information is saved only in the case when Tile raw channel container comes from the DSP, and when there are errors in the metadata for the corresponding module. That means that the metadata are saved only for problematic modules.

To save space some errors (header format and parity errors, sample format and parity errors, FE and ROD chip mask errors) are merged into one (memory parity error).

The test for the Tile raw channel converter has been modified to test this functionality and the corresponing reference file has been update also.

This merge request affects 1 package:

• TileCalorimeter/TileSvc/TileTPCnv

This merge request affects 3 files:

• TileCalorimeter/TileSvc/TileTPCnv/TileTPCnv/T_TilePoolContainerCnv.h
• TileCalorimeter/TileSvc/TileTPCnv/share/TileRawChannelContainerCnv_p1_test.ref
• TileCalorimeter/TileSvc/TileTPCnv/test/TileRawChannelContainerCnv_p1_test.cxx

Adding @gemmeren ,@solodkov ,@iouri ,@pavol ,@harkusha as watchers

added 24.0 Tile review-pending-level-1 labels

added Run2-DataReco-output-changed Run3-DataReco-output-changed labels

CI Result FAILURE (hash a21897f5)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Please take a look at the failing test. -L1

added review-user-action-required label and removed review-pending-level-1 label

I suspect the change is expected, but it would be nice if @harkusha can confirm.

added RC Attention Required label

removed review-user-action-required label

added review-pending-expert label

resolved all threads

Just a minor comment, otherwise code changes look good. The CI will need to be rerun in any case to update the references.

added review-user-action-required label and removed review-pending-expert label

added 1 commit

• 6729eff3 - TileTPCnv: Avoid FT0 policy violation

Compare with previous version

This merge request affects 1 package:

• TileCalorimeter/TileSvc/TileTPCnv

This merge request affects 3 files:

• TileCalorimeter/TileSvc/TileTPCnv/TileTPCnv/T_TilePoolContainerCnv.h
• TileCalorimeter/TileSvc/TileTPCnv/share/TileRawChannelContainerCnv_p1_test.ref
• TileCalorimeter/TileSvc/TileTPCnv/test/TileRawChannelContainerCnv_p1_test.cxx

Adding @solodkov ,@harkusha ,@iouri ,@gemmeren ,@pavol as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 6729eff3)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

removed Run2-DataReco-output-changed label

removed Run3-DataReco-output-changed label

removed RC Attention Required label

resolved all threads

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added review-approved-tier0 label

merged

mentioned in commit dbc10a9b

mentioned in merge request !77791 (merged)