Skip to content
Snippets Groups Projects

FPGATrackSim: Implemented use of a layer map to make slice dependent layer assignments

Merged Elliot Lipeles requested to merge lipeles/athena:lipeles_dev3 into main
All threads resolved!

Added code to read a layer map from a JSON file and use it to assign layers after binning. The layer map is set in the python with hooks to set it as a command line flag "Trigger.FPGATrackSim.GenScan.layerMapFile=path/lyrmap.json". The default behavior is unchanged. If the layer map is set then its used.

@wcastigl @jahreda @brosser

Merge request reports

Checking pipeline status.

Merged by Tadej NovakTadej Novak 1 month ago (Feb 5, 2025 6:19pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Author Developer
      Resolved by Elliot Lipeles

      Yeah, the layer assignment for a hit might be different for different slices, so which hit is in which layer has to be communicated through the "road" object. Luckily, when I looked at the combinatorial engine in the tracking code, this seems to be the case.

      It does leave open the possibility of misunderstanding, but at this point removing "layer" from the hits is hard.

  • :white_check_mark: CI Result SUCCESS (hash 225c0442)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Please take a look at the unresolved threads. - L1 shifter

  • Elliot Lipeles resolved all threads

    resolved all threads

  • All threads resolved, approving from L1 side

  • merged

  • Tadej Novak mentioned in commit 5d7c7fa3

    mentioned in commit 5d7c7fa3

  • Please register or sign in to reply
    Loading