Skip to content
Snippets Groups Projects

ATR-30736 Relax HLT 2b preselection to 1b where possible

Merged Francesco Curcio requested to merge fcurcio/athena:TM-03Feb2025 into 24.0

chains listed in this ticket were duplicated in the corresponding menus.

tagging: @khoo @cpollard @mmontell @lshi @boliu @syan to check everything is there

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Francesco Curcio resolved all threads

    resolved all threads

  • added 1 commit

    • c61a0966 - removed commented lines from Dev menu

    Compare with previous version

  • Francesco Curcio marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • Trigger/TriggerCommon/TriggerMenuMT

    This merge request affects 3 files:

    • Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/MC_pp_run3_v1.py
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py
    • Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/SignatureDicts.py

    Adding @lidiaz ,@ggonella ,@slai ,@sutt ,@ademaria ,@iriu ,@carquin ,@jmcgowan ,@shanisch ,@gipezzul as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 356K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

  • :x: CI Result FAILURE (hash c61a0966)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added 1 commit

    Compare with previous version

  • This merge request affects 3 packages:

    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @ademaria ,@lidiaz ,@carquin ,@slai ,@iriu ,@salderwe ,@shanisch ,@okumura ,@martindl ,@vmartin ,@gipezzul ,@sutt ,@ggonella ,@jmcgowan as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 408K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

    :pencil: 260K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 356K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

  • Gianantonio Pezzullo resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 70b9f241)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added review-approved label and removed review-pending-level-1 label

  • Changes and CI look fine. Approving.

    Kira (L1)

  • @fcurcio, this MR looks fine and I am happy to have it merged. Could you first resolve the conflict?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading