purge unstable particles from Hijing

Occasionally, Hijing produces unstable particles (i.e. with status=2) without end vertex. That is disliked by simulation that throws errors because of that.

It was attempted to fix it by filtering such particles, see !65417 (merged). Unfortunately, FixHepMC can also delete particles, and if it removes the last outgoing particle from the vertex, it also deletes the vertex. This leaves the mother particle without the end vertex, leading to problems in simulation.

This MR moves the filtering to FixHepMC, removing all particles without end vertex regardless if created by Hijing or by FixHepMC. It also switche this filtering on for Hijing; behaviour of all other generators is unchanged.

tagging @stapiaar @ewelina @tbold

related JIRA ticket: ATLHI-483

added Generators HeavyIon main labels

Jenkins please retry a build

This merge request affects 3 packages:

• Generators/EvgenJobTransforms
• Generators/EvgenProdTools
• Generators/Hijing_i

Affected files list will not be printed in this case

It looks great! Thanks @pbalek

CI Result SUCCESS (hash c06479cb)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• c423acdd - purge unstable particles from Hijing

Compare with previous version

resolved all threads

marked this merge request as ready

This merge request affects 3 packages:

• Generators/EvgenJobTransforms
• Generators/EvgenProdTools
• Generators/Hijing_i

Affected files list will not be printed in this case

added review-pending-level-1 label

CI Result SUCCESS (hash c423acdd)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 04c13651