From 72349e46cd1e9cd677d7607e9aa4aaa0c44ae5ff Mon Sep 17 00:00:00 2001
From: sss <sss@karma>
Date: Fri, 7 Feb 2025 03:39:00 -0500
Subject: [PATCH] MuonCondDump: Fix clang warnings.
Binding references to temporariesa in range-for.
---
.../MuonCondDump/src/MdtCalibJsonDumpAlg.cxx | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondDump/src/MdtCalibJsonDumpAlg.cxx b/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondDump/src/MdtCalibJsonDumpAlg.cxx
index 37a0613269a5..c8524d10c0f3 100644
--- a/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondDump/src/MdtCalibJsonDumpAlg.cxx
+++ b/MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondDump/src/MdtCalibJsonDumpAlg.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
*/
#include "MdtCalibJsonDumpAlg.h"
#include "StoreGate/ReadCondHandle.h"
@@ -143,13 +143,13 @@ namespace Muon {
outFileRT<<"[\n";
const MdtIdHelper& idHelper{m_idHelperSvc->mdtIdHelper()};
nlohmann::json rtDump{};
- for (const auto& [counter, payload] : Acts::enumerate(rtRelMap)) {
+ for (const auto [counter, payload] : Acts::enumerate(rtRelMap)) {
outFileRT<<whiteSpace(m_whiteSpace)<<"{\n";
outFileRT<<whiteSpace(m_whiteSpace)<<" \"chambers\": [\n";
const MdtRtRelation* rtRel = payload.first;
const std::set<Identifier>& chambers = payload.second;
- for (const auto& [chCounter, chambId] : Acts::enumerate(chambers)) {
+ for (const auto [chCounter, chambId] : Acts::enumerate(chambers)) {
outFileRT<<whiteSpace(2*m_whiteSpace)<<"{"
<<std::format("\"station\": \"{:}\", \"eta\": {:2d}, \"phi\": {:1d}, \"ml\": {:1d}",
idHelper.stationNameString(idHelper.stationName(chambId)), idHelper.stationEta(chambId),
@@ -201,7 +201,7 @@ namespace Muon {
std::string MdtCalibJsonDumpAlg::dump(const std::vector<double>& values) const{
std::stringstream sstr{};
sstr<<"[";
- for (const auto& [count, v] : Acts::enumerate(values)) {
+ for (const auto [count, v] : Acts::enumerate(values)) {
sstr<<dump(v);
if (count + 1 != values.size())sstr<<", ";
}
@@ -225,7 +225,7 @@ namespace Muon {
}
outFileT0<<"[\n";
const MdtIdHelper& idHelper{m_idHelperSvc->mdtIdHelper()};
- for (const auto& [count, payload] : Acts::enumerate(t0Map)) {
+ for (const auto [count, payload] : Acts::enumerate(t0Map)) {
outFileT0<<whiteSpace(m_whiteSpace)<<"{\n";
const Identifier& detId = payload.first;
const T0PerChamb& calibConstants = payload.second;
@@ -238,7 +238,7 @@ namespace Muon {
<<std::format("\"station\": \"{:}\", \"eta\": {:2d}, \"phi\": {:1d}, \"calibConstants\":[\n",
idHelper.stationNameString(idHelper.stationName(detId)),
idHelper.stationEta(detId), idHelper.stationPhi(detId));
- for (const auto& [calibCounter, calibPayload] : Acts::enumerate(calibConstants)) {
+ for (const auto [calibCounter, calibPayload] : Acts::enumerate(calibConstants)) {
outFileT0<<whiteSpace(2*m_whiteSpace)<<"{\"t0\": "<<dump(calibPayload.first->t0)<<", ";
outFileT0<<"\"adc\": "<<dump(calibPayload.first->adcCal)<<", ";
outFileT0<<"\"code\": "<<dump(calibPayload.first->statusCode)<<", ";
@@ -302,4 +302,4 @@ namespace Muon {
}
return {};
}
-}
\ No newline at end of file
+}
--
GitLab