changes in the config files to be compatible with phase2 geometry
MuonSpectrometer/MuonConfig/python/MuonRdoDecodeConfig.py
: I changed the name of the RpcRdoToRpcDigitCfg alg as multiple config fragments in the trigger create different components with the same name
MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/NrpcDigitToNrpcRDO.h
: I changed the name of the RpcDIgitContainer with a more meaningful one that matches the one used in configurion files, see RpcRdoToPrepDataToolCfg in RpcRdoToPrepDataToolCfg.py.
Trigger/TrigT1/TrigT1MuonRecRoiTool/python/TrigT1MuonRecRoiToolConfig.py
: I removed the configuration lines that were setting some containerKeys in the tool and MuonDetectorCondAlg, ensuring that the default values matches.
Targets: ATR-30883
Merge request reports
Activity
added full-unit-tests label
- Resolved by Leonardo Monaco
added MuonSpectrometer Trigger main review-pending-level-1 labels
added 1 commit
- 9ca79efb - Changing the deafult name of the alg when it is created, rather than changing...
This merge request affects 4 packages:
- MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
- Trigger/TrigT1/TrigT1MuonRecRoiTool
Affected files list will not be printed in this case
Adding @apsallid ,@jojungge ,@markowen ,@stavrop ,@mvozak ,@ddicroce ,@wleight ,@kluit ,@pscholer as watchers
added Upgrade label
CI Result FAILURE (hash b32dfcf5)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added review-user-action-required label
removed review-pending-level-1 label
CI Result FAILURE (hash 9ca79efb)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added 1 commit
- d9e4281f - Setting the correct tool name MuonDetectorCondName in testGeoModel.py in...
This merge request affects 5 packages:
- MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
- Trigger/TrigT1/TrigT1MuonRecRoiTool
Affected files list will not be printed in this case
Adding @pscholer ,@kluit ,@jojungge ,@apsallid ,@wleight ,@stavrop ,@ddicroce ,@mvozak ,@markowen as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash d9e4281f)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added review-approved label
removed review-pending-level-1 label