Skip to content
Snippets Groups Projects

changes in the config files to be compatible with phase2 geometry

Merged Leonardo Monaco requested to merge lmonaco/athena:configChangesForTrigComp into main

MuonSpectrometer/MuonConfig/python/MuonRdoDecodeConfig.py: I changed the name of the RpcRdoToRpcDigitCfg alg as multiple config fragments in the trigger create different components with the same name MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/NrpcDigitToNrpcRDO.h: I changed the name of the RpcDIgitContainer with a more meaningful one that matches the one used in configurion files, see RpcRdoToPrepDataToolCfg in RpcRdoToPrepDataToolCfg.py. Trigger/TrigT1/TrigT1MuonRecRoiTool/python/TrigT1MuonRecRoiToolConfig.py: I removed the configuration lines that were setting some containerKeys in the tool and MuonDetectorCondAlg, ensuring that the default values matches.

Targets: ATR-30883

Edited by Leonardo Monaco

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 3 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonConfig
    • Trigger/TrigT1/TrigT1MuonRecRoiTool

    Affected files list will not be printed in this case

    Adding @kluit ,@apsallid ,@mvozak ,@pscholer ,@stavrop ,@jojungge as watchers

  • Leonardo Monaco resolved all threads

    resolved all threads

  • added 1 commit

    • 9ca79efb - Changing the deafult name of the alg when it is created, rather than changing...

    Compare with previous version

  • This merge request affects 4 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
    • Trigger/TrigT1/TrigT1MuonRecRoiTool

    Affected files list will not be printed in this case

    Adding @apsallid ,@jojungge ,@markowen ,@stavrop ,@mvozak ,@ddicroce ,@wleight ,@kluit ,@pscholer as watchers

  • added Upgrade label

  • :x: CI Result FAILURE (hash b32dfcf5)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Please check the failing tests

    	1589 - MuonGeoModelTestR4_testR3Geometry_ctest (Failed)
    	1591 - MuonGeoModelTestR4_testR3GeometryData_ctest (Failed)
    	1592 - MuonGeoModelTestR4_testR4Geometry_ctest (Failed)
  • :x: CI Result FAILURE (hash 9ca79efb)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added 1 commit

    • d9e4281f - Setting the correct tool name MuonDetectorCondName in testGeoModel.py in...

    Compare with previous version

  • This merge request affects 5 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
    • MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
    • Trigger/TrigT1/TrigT1MuonRecRoiTool

    Affected files list will not be printed in this case

    Adding @pscholer ,@kluit ,@jojungge ,@apsallid ,@wleight ,@stavrop ,@ddicroce ,@mvozak ,@markowen as watchers

  • :white_check_mark: CI Result SUCCESS (hash d9e4281f)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading