Modifying NRPC RDO

A modification to the NRPC RDO variable names and access function naming is introduced. Reason is that the NRPC (BIS 7/8) will have a tdc board in run-3, but this will change in phase-2 when a new readout board (with no tdc) will be used. In order to keep the RDO valid for phase-2 tdc has to be replaced with board in NRPC RDO's and in all related classes. No change is applied to the actual RDO content and size.

cc @mnegrini

added 1 commit

• c9ce6df8 - fix NRDO dependencies

Compare with previous version

marked this merge request as ready

This merge request affects 4 packages:

• Event/xAOD/xAODMuonRDO
• MuonSpectrometer/MuonCablings/MuonCablingData
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools

Affected files list will not be printed in this case

Adding @jojungge ,@apsallid ,@akraszna ,@kluit ,@stavrop ,@pscholer ,@mvozak as watchers

added 24.0 EDM MuonSpectrometer review-pending-level-1 labels

changed the description

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash c9ce6df8)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 00ec729d - NRPC cabling namings

Compare with previous version

This merge request affects 5 packages:

• Event/xAOD/xAODMuonRDO
• MuonSpectrometer/MuonCablings/MuonCablingData
• MuonSpectrometer/MuonCablings/MuonNRPC_Cabling
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools

Affected files list will not be printed in this case

Adding @kluit ,@akraszna ,@mvozak ,@jojungge ,@pscholer ,@stavrop ,@apsallid as watchers

CI Result SUCCESS (hash 00ec729d)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added sweep:ignore label

removed review-approved label

added review-user-action-required label

changed the description

added 1 commit

• 073e1b2b - fix json file preparation of NRC cabling

Compare with previous version

This merge request affects 5 packages:

• Event/xAOD/xAODMuonRDO
• MuonSpectrometer/MuonCablings/MuonCablingData
• MuonSpectrometer/MuonCablings/MuonNRPC_Cabling
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools

Affected files list will not be printed in this case

Adding @akraszna ,@pscholer ,@kluit ,@apsallid ,@stavrop ,@jojungge ,@mvozak as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 073e1b2b)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• ee71154e - updating RPC cabling map version

Compare with previous version

This merge request affects 6 packages:

• Event/xAOD/xAODMuonRDO
• MuonSpectrometer/MuonCablings/MuonCablingData
• MuonSpectrometer/MuonCablings/MuonNRPC_Cabling
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
• MuonSpectrometer/MuonConfig

Affected files list will not be printed in this case

Adding @kluit ,@jojungge ,@akraszna ,@pscholer ,@stavrop ,@mvozak ,@apsallid as watchers

resolved all threads

CI Result SUCCESS (hash ee71154e)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

added review-approved-point1 label

added review-approved-tier0 label

merged

mentioned in commit b370533b

mentioned in merge request !77896 (merged)

mentioned in merge request !77912 (merged)