diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx index 5d13fc6ad4a6a6a2dcf342a7ec9d9a3f28066def..2a2c5f98caeb65804860b757e080edab42351f8e 100644 --- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx +++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx @@ -450,7 +450,7 @@ StatusCode FPGATrackSimDataFlowTool::printDataFlow(std::string const & key, int // Replace all "<" by "$<$" in the key to make the type text for tex. // If there are other characters in the future, we can make a vector to store all of them. - std::string key_tex = str_key; + std::string key_tex = std::move(str_key); findAndReplaceAll(key_tex, "<", "$<$"); m_dataFlowTeX << key_tex << " & " << str_stage << " & " << roundTo(mean, m_nSigDigits) diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx index 1b996de4ed1b95fef925867b242730481962db57..a1af9ce44211255bfe9139ee4a7de7ea392a20ab 100755 --- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx +++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx @@ -503,7 +503,7 @@ StatusCode FPGATrackSimLogicalHitsProcessAlg::finalize() void FPGATrackSimLogicalHitsProcessAlg::printHitSubregions(std::vector<FPGATrackSimHit> const & hits) { ATH_MSG_WARNING("Hit regions:"); - for (auto hit : hits) + for (const auto& hit : hits) { std::vector<uint32_t> regions = m_FPGATrackSimMapping->SubRegionMap()->getRegions(hit); std::stringstream ss; diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx index 1e187592b33ccf121bd02ae6bec7c0b5caae44ea..0c58ea06e95c3300899b50cc929440a34cc8c248 100644 --- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx +++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx @@ -8,14 +8,14 @@ OnnxRuntimeBase::OnnxRuntimeBase(TString fileName) { - initialize(fileName); + initialize(std::move(fileName)); } OnnxRuntimeBase::OnnxRuntimeBase() {} void OnnxRuntimeBase::initialize(TString fileName) { - m_fileName = fileName; + m_fileName = std::move(fileName); //load the onnx model to memory using the path m_path_to_onnx m_env = std::make_unique< Ort::Env >(ORT_LOGGING_LEVEL_WARNING, ""); @@ -213,7 +213,7 @@ std::map<int, Eigen::MatrixXf> OnnxRuntimeBase::runONNXInferenceMultilayerOutput } batchMatrix.row(j) = vec; } // batch - outputTensorMap[i] = batchMatrix; + outputTensorMap[i] = std::move(batchMatrix); } // output layers return outputTensorMap; } diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx index dfcc87667cfe13083c25944e396da274cbd85aa0..693d9759c68ee9bd4cdacf70b25721f2e24ed1e3 100644 --- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx +++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx @@ -609,7 +609,7 @@ void FPGATrackSimGenScanMonitoring::pairSetFilterCheck( unsigned threshold) { m_pairsets->Fill(pairsets.size()); - for (auto pairset : pairsets) { + for (const auto& pairset : pairsets) { // if over threshold add it to the output if (pairset.lyrCnt() >= threshold) { m_roadFilterFlow->Fill(3); diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx index 3afeb2d2c6e9a8694cf23a0cd2cf51f581f7c71f..0509a9665bed7846a61c09b6a8dbf064927093c0 100755 --- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx +++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx @@ -316,11 +316,11 @@ StatusCode FPGATrackSimGenScanTool::fillImage(const std::vector<std::shared_ptr< if (m_mod_to_lyr_map.size() != 0) { if (m_mod_to_lyr_map[idx].contains(hit->getIdentifier())) { s_hit.layer = m_mod_to_lyr_map[idx][hit->getIdentifier()]; - m_image[idx].addHit(s_hit); + m_image[idx].addHit(std::move(s_hit)); } } else { // add hit to the BinEntry for the bin - m_image[idx].addHit(s_hit); + m_image[idx].addHit(std::move(s_hit)); } } diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx index 2e339a4406a81bb5632478fd6eb3b2b535fc186f..c0c8ffc12541438c6e328cd5f55622e497c27a66 100644 --- a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx +++ b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx @@ -149,7 +149,7 @@ TrigConf::HLTPrescaleSetLoader::load( HLTPrescaleSet& hltpss ) { .setPrescale(ps) .setPassThrough(pt); } else { - std::string streamnametype(level); + std::string streamnametype(std::move(level)); // sanity check: stream name and type are separated by ':' if(streamnametype.rfind(':')==std::string::npos) streamnametype += ":" + streamnametype; diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx index 3189555f0437dbdbb974ad67a1adbe307739f2cd..3ec3cd770f882d3bafd9bf06dc5a38c7157b7613 100644 --- a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx +++ b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx @@ -141,7 +141,7 @@ TrigConf::HLTSequenceLoader::loadSequences( HLTSequenceList& seqlist ) { alg_list.resize( alg_pos+1, "" ); if(auto &algitem = alg_list[alg_pos]; algitem.empty()) { - algitem = alg_name; + algitem = std::move(alg_name); } else { if(algitem != alg_name) { cerr << "Two different algs in the same position " << alg_pos << endl; diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx index df96b2ee54419b6b4965db0948d94781a0d81237..5846b0d9c0635a8e6389138e4099a7ea449d0823 100644 --- a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx +++ b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx @@ -643,7 +643,7 @@ TrigConf::TrigConfCoolWriter::writeL1MonPayload( const RunRangeVec& runRanges, mults[index]=strMult.str(); starts[index]=strStart.str(); ends[index]=strEnd.str(); - actives[index]=active; + actives[index]=std::move(active); counterType[index]=(*mc)->counterType(); bgId[index]=(*mc)->bunchGroupId(); // not possible yet diff --git a/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx b/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx index 476220abec614ea8a251bf43f5a5dc775e80e9b1..ce6fae5dbd30e5a5404de0a951767bb9f7b25b41 100644 --- a/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx +++ b/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx @@ -311,7 +311,7 @@ std::unordered_map<std::string, ChainDetail> EnhancedBiasWeighter::parsePrescale // Later processing here does not expect any spaces, so remove them now. Pure comma separated list std::string lower = xml->GetNodeContent(sigDetailsNode); while (lower.find(" ") != std::string::npos) lower.replace( lower.find(" "), 1, ""); - result[chainName].m_lowerName = lower; + result[chainName].m_lowerName = std::move(lower); } else if (detail == "evts_passed") { result[chainName].m_eventsPassed = std::stod( xml->GetNodeContent(sigDetailsNode) ); } else if (detail == "evts_passed_weighted") { diff --git a/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx b/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx index bbf88b1a7326d40e5ae0aa9849f2c19edb5f3452..2838808067c4d4000ae208c19c0d6166eb2bdf5b 100644 --- a/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx +++ b/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx @@ -224,7 +224,7 @@ StatusCode TrigSerializeConvHelper::createRep(const std::string &clname, if (m_doTP and !isxAOD){ std::string persclass(""); pObj = m_TPTool->convertTP(clname,ptr, persclass); - cl = persclass; + cl = std::move(persclass); } ATH_MSG_DEBUG("convertTP: " << pObj << " of " << cl);