From 7eda8eba118f4610b8a84788e14106fe9e3417e0 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 15:41:28 +0100
Subject: [PATCH 01/12] use move instead of copy
---
.../FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx
index 5d13fc6ad4a6..2a2c5f98caeb 100644
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimDataFlowTool.cxx
@@ -450,7 +450,7 @@ StatusCode FPGATrackSimDataFlowTool::printDataFlow(std::string const & key, int
// Replace all "<" by "$<$" in the key to make the type text for tex.
// If there are other characters in the future, we can make a vector to store all of them.
- std::string key_tex = str_key;
+ std::string key_tex = std::move(str_key);
findAndReplaceAll(key_tex, "<", "$<$");
m_dataFlowTeX << key_tex << " & " << str_stage << " & " << roundTo(mean, m_nSigDigits)
--
GitLab
From 728be296266f0c451b60a5b180800284d887ebfe Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 15:44:29 +0100
Subject: [PATCH 02/12] use const auto& instead of auto
---
.../src/FPGATrackSimLogicalHitsProcessAlg.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx
index 1b996de4ed1b..a1af9ce44211 100755
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimLogicalHitsProcessAlg.cxx
@@ -503,7 +503,7 @@ StatusCode FPGATrackSimLogicalHitsProcessAlg::finalize()
void FPGATrackSimLogicalHitsProcessAlg::printHitSubregions(std::vector<FPGATrackSimHit> const & hits)
{
ATH_MSG_WARNING("Hit regions:");
- for (auto hit : hits)
+ for (const auto& hit : hits)
{
std::vector<uint32_t> regions = m_FPGATrackSimMapping->SubRegionMap()->getRegions(hit);
std::stringstream ss;
--
GitLab
From b2e9eb6b1169a3841e8bde4e9a2375ae20c3b1f7 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 15:50:12 +0100
Subject: [PATCH 03/12] use move instead of copy
---
.../FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
index 1e187592b33c..e839323f4fec 100644
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
@@ -213,7 +213,7 @@ std::map<int, Eigen::MatrixXf> OnnxRuntimeBase::runONNXInferenceMultilayerOutput
}
batchMatrix.row(j) = vec;
} // batch
- outputTensorMap[i] = batchMatrix;
+ outputTensorMap[i] = std::move(batchMatrix);
} // output layers
return outputTensorMap;
}
--
GitLab
From 4885df868ea50fe76f66d680fc08adca24a20d67 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 15:59:04 +0100
Subject: [PATCH 04/12] use move instead of copy.
or we can replace fileName with m_fileName in function signature!
---
.../FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
index e839323f4fec..ea2c9893a8cb 100644
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
@@ -15,7 +15,7 @@ OnnxRuntimeBase::OnnxRuntimeBase() {}
void OnnxRuntimeBase::initialize(TString fileName)
{
- m_fileName = fileName;
+ m_fileName = std::move(fileName);
//load the onnx model to memory using the path m_path_to_onnx
m_env = std::make_unique< Ort::Env >(ORT_LOGGING_LEVEL_WARNING, "");
--
GitLab
From 81a047f2c674dafe6a62f6da56f2ca1e3c0570a2 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 16:00:38 +0100
Subject: [PATCH 05/12] use move instead of copy
---
.../FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
index ea2c9893a8cb..0c58ea06e95c 100644
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/OnnxRuntimeBase.cxx
@@ -8,7 +8,7 @@
OnnxRuntimeBase::OnnxRuntimeBase(TString fileName)
{
- initialize(fileName);
+ initialize(std::move(fileName));
}
OnnxRuntimeBase::OnnxRuntimeBase() {}
--
GitLab
From e9fd7595a55ef4ac4e7cddddf8f679a8b8df76dd Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 16:03:25 +0100
Subject: [PATCH 06/12] use const auto& instead of auto
---
.../FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx
index dfcc87667cfe..693d9759c68e 100644
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanMonitoring.cxx
@@ -609,7 +609,7 @@ void FPGATrackSimGenScanMonitoring::pairSetFilterCheck(
unsigned threshold) {
m_pairsets->Fill(pairsets.size());
- for (auto pairset : pairsets) {
+ for (const auto& pairset : pairsets) {
// if over threshold add it to the output
if (pairset.lyrCnt() >= threshold) {
m_roadFilterFlow->Fill(3);
--
GitLab
From d324de5cb0c908fad3f36f86bd8507d78e6562b9 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Fri, 14 Feb 2025 16:06:28 +0100
Subject: [PATCH 07/12] use move instead of copy
---
.../FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx
index 3afeb2d2c6e9..0509a9665bed 100755
--- a/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx
+++ b/Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimGenScanTool.cxx
@@ -316,11 +316,11 @@ StatusCode FPGATrackSimGenScanTool::fillImage(const std::vector<std::shared_ptr<
if (m_mod_to_lyr_map.size() != 0) {
if (m_mod_to_lyr_map[idx].contains(hit->getIdentifier())) {
s_hit.layer = m_mod_to_lyr_map[idx][hit->getIdentifier()];
- m_image[idx].addHit(s_hit);
+ m_image[idx].addHit(std::move(s_hit));
}
} else {
// add hit to the BinEntry for the bin
- m_image[idx].addHit(s_hit);
+ m_image[idx].addHit(std::move(s_hit));
}
}
--
GitLab
From dcfdcdbfd305d0c324e455a4f3451c0a1d1b4bed Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Sat, 15 Feb 2025 22:32:35 +0100
Subject: [PATCH 08/12] use move instead of copy
---
.../TrigConfStorage/src/apps/TrigConfCoolWriter.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx
index df96b2ee5441..5846b0d9c063 100644
--- a/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx
+++ b/Trigger/TrigConfiguration/TrigConfStorage/src/apps/TrigConfCoolWriter.cxx
@@ -643,7 +643,7 @@ TrigConf::TrigConfCoolWriter::writeL1MonPayload( const RunRangeVec& runRanges,
mults[index]=strMult.str();
starts[index]=strStart.str();
ends[index]=strEnd.str();
- actives[index]=active;
+ actives[index]=std::move(active);
counterType[index]=(*mc)->counterType();
bgId[index]=(*mc)->bunchGroupId();
// not possible yet
--
GitLab
From 2c19dabe6283a64fb3aae4b6bbeabe104a7e7602 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Sat, 15 Feb 2025 22:34:57 +0100
Subject: [PATCH 09/12] move instead of copy
---
.../TrigConfStorage/src/HLTPrescaleSetLoader.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx
index 2e339a4406a8..c0c8ffc12541 100644
--- a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx
+++ b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTPrescaleSetLoader.cxx
@@ -149,7 +149,7 @@ TrigConf::HLTPrescaleSetLoader::load( HLTPrescaleSet& hltpss ) {
.setPrescale(ps)
.setPassThrough(pt);
} else {
- std::string streamnametype(level);
+ std::string streamnametype(std::move(level));
// sanity check: stream name and type are separated by ':'
if(streamnametype.rfind(':')==std::string::npos)
streamnametype += ":" + streamnametype;
--
GitLab
From e5e7e0d3dc0383dcde4ec011c77eb3ba21b05fde Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Sat, 15 Feb 2025 22:37:22 +0100
Subject: [PATCH 10/12] use move instead of copy
---
.../TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx
index 3189555f0437..3ec3cd770f88 100644
--- a/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx
+++ b/Trigger/TrigConfiguration/TrigConfStorage/src/HLTSequenceLoader.cxx
@@ -141,7 +141,7 @@ TrigConf::HLTSequenceLoader::loadSequences( HLTSequenceList& seqlist ) {
alg_list.resize( alg_pos+1, "" );
if(auto &algitem = alg_list[alg_pos]; algitem.empty()) {
- algitem = alg_name;
+ algitem = std::move(alg_name);
} else {
if(algitem != alg_name) {
cerr << "Two different algs in the same position " << alg_pos << endl;
--
GitLab
From 650805c38cfdcd1db81e5d2b126418e949b5c2b9 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Sat, 15 Feb 2025 22:41:49 +0100
Subject: [PATCH 11/12] use move instead of copy
---
.../TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx b/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx
index 476220abec61..ce6fae5dbd30 100644
--- a/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx
+++ b/Trigger/TrigCost/EnhancedBiasWeighter/Root/EnhancedBiasWeighter.cxx
@@ -311,7 +311,7 @@ std::unordered_map<std::string, ChainDetail> EnhancedBiasWeighter::parsePrescale
// Later processing here does not expect any spaces, so remove them now. Pure comma separated list
std::string lower = xml->GetNodeContent(sigDetailsNode);
while (lower.find(" ") != std::string::npos) lower.replace( lower.find(" "), 1, "");
- result[chainName].m_lowerName = lower;
+ result[chainName].m_lowerName = std::move(lower);
} else if (detail == "evts_passed") {
result[chainName].m_eventsPassed = std::stod( xml->GetNodeContent(sigDetailsNode) );
} else if (detail == "evts_passed_weighted") {
--
GitLab
From df28ed4219d893bcd2ede606ed177531a1734a81 Mon Sep 17 00:00:00 2001
From: Meisam Farzalipour Tabriz <36428-mfarzali@users.noreply.gitlab.cern.ch>
Date: Sat, 15 Feb 2025 22:43:38 +0100
Subject: [PATCH 12/12] use move instead of copy
---
.../TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx b/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx
index bbf88b1a7326..2838808067c4 100644
--- a/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx
+++ b/Trigger/TrigDataAccess/TrigSerializeCnvSvc/src/TrigSerializeConvHelper.cxx
@@ -224,7 +224,7 @@ StatusCode TrigSerializeConvHelper::createRep(const std::string &clname,
if (m_doTP and !isxAOD){
std::string persclass("");
pObj = m_TPTool->convertTP(clname,ptr, persclass);
- cl = persclass;
+ cl = std::move(persclass);
}
ATH_MSG_DEBUG("convertTP: " << pObj << " of " << cl);
--
GitLab