Adding skeleton of L0 Muon RPC sim
Adding a first version of the stage-1 simulation alg for the L0 muon barrel trigger, based on RPC.
The package includes the skeleton of an alg, to be completed with the actual implementation of the coincidences, and the initial preparation of the RoI container to be exchanged with the MDT TP simulation.
A configuration is also included.
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigT1/Muon/L0MuonS1RPC
This merge request affects 5 files:
- Trigger/TrigT1/Muon/L0MuonS1RPC/CMakeLists.txt
- Trigger/TrigT1/Muon/L0MuonS1RPC/python/L0MuonS1RPCConfig.py
- Trigger/TrigT1/Muon/L0MuonS1RPC/src/L0MuonRPCSim.cxx
- Trigger/TrigT1/Muon/L0MuonS1RPC/src/L0MuonRPCSim.h
- Trigger/TrigT1/Muon/L0MuonS1RPC/src/components/L0MuonS1RPC_entries.cxx
Adding @junpei as watcher
added Trigger main review-pending-level-1 labels
-
Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added review-pending-level-2 label and removed review-pending-level-1 label
added review-approved label and removed review-pending-level-2 label
mentioned in commit 821d6b0f
mentioned in merge request !78109 (merged)
This slipped through and I only saw this MR when looking at the very similar !78109 (merged). I have quite a few comments that need to be addressed as a follow-up MR.
2 Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration 3 */ 4 #ifndef L0MUONRPCSIM_H 5 #define L0MUONRPCSIM_H 6 7 #include "AthenaBaseComps/AthReentrantAlgorithm.h" 8 #include "AthenaMonitoringKernel/Monitored.h" 9 #include "AthenaKernel/IAthRNGSvc.h" 10 11 #include "StoreGate/ReadHandleKey.h" 12 #include "xAODMuonRDO/NRPCRDOContainer.h" 13 #include "xAODTrigger/MuonRoIContainer.h" 14 #include "MuonDigitContainer/RpcDigitContainer.h" 15 #include "MuonCablingData/RpcCablingMap.h" 16 17 namespace L0Muon { -
Please read our naming convention guidelines: https://atlassoftwaredocs.web.cern.ch/coding-guidelines/
Your full class name is now
L0Muon::L0MuonRPCSim, i.e. you are duplicating the prefix. Please decide as a community if you use the namespace or the class prefix. But not both.
1 /* 2 Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration 3 */ 4 #ifndef L0MUONRPCSIM_H 5 #define L0MUONRPCSIM_H 6 7 #include "AthenaBaseComps/AthReentrantAlgorithm.h" 8 #include "AthenaMonitoringKernel/Monitored.h" 9 #include "AthenaKernel/IAthRNGSvc.h" 1 # Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration 2 3 atlas_subdir ( L0MuonS1RPC ) 4 5 find_package( CLHEP ) 6 7 atlas_add_component (L0MuonS1RPC 8 src/*.cxx src/components/*.cxx 9 INCLUDE_DIRS ${CLHEP_INCLUDE_DIRS} 10 LINK_LIBRARIES AnaAlgorithmLib AthenaKernel xAODMuonRDO MuonDigitContainer xAODTrigger AthenaMonitoringKernelLib 20 21 ATH_CHECK(m_keyRpcRdo.initialize()); 22 ATH_CHECK(m_keyRpcDigit.initialize()); 23 ATH_CHECK(m_cablingKey.initialize()); 24 25 /// container of output RoIs 26 ATH_CHECK(m_outputMuonRoIKey.initialize()); 27 28 /// retrieve the monitoring tool 29 if (!m_monTool.empty()) ATH_CHECK(m_monTool.retrieve()); 30 31 return StatusCode::SUCCESS; 32 } 33 34 35 StatusCode L0MuonRPCSim::finalize() { 32 } 33 34 35 StatusCode L0MuonRPCSim::finalize() { 36 ATH_MSG_INFO ("Finalizing " << name() << "..."); 37 return StatusCode::SUCCESS; 38 } 39 40 41 StatusCode L0MuonRPCSim::execute(const EventContext& ctx) const { 42 ATH_MSG_DEBUG ("Executing " << name() << "..."); 43 44 SG::ReadHandle<xAOD::NRPCRDOContainer> rpcRdo_handle(m_keyRpcRdo,ctx); 45 const xAOD::NRPCRDOContainer* inputRDO = rpcRdo_handle.cptr(); 46 if ( not inputRDO ) { 47 ATH_MSG_FATAL("Unable to retrieve input RPC RDO container: " << m_keyRpcRdo.key()); -
And algorithm should never print
FATAL.Change toERRORand see https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/ReportingErrors
30 31 return StatusCode::SUCCESS; 32 } 33 34 35 StatusCode L0MuonRPCSim::finalize() { 36 ATH_MSG_INFO ("Finalizing " << name() << "..."); 37 return StatusCode::SUCCESS; 38 } 39 40 41 StatusCode L0MuonRPCSim::execute(const EventContext& ctx) const { 42 ATH_MSG_DEBUG ("Executing " << name() << "..."); 43 44 SG::ReadHandle<xAOD::NRPCRDOContainer> rpcRdo_handle(m_keyRpcRdo,ctx); 45 const xAOD::NRPCRDOContainer* inputRDO = rpcRdo_handle.cptr(); 43 44 SG::ReadHandle<xAOD::NRPCRDOContainer> rpcRdo_handle(m_keyRpcRdo,ctx); 45 const xAOD::NRPCRDOContainer* inputRDO = rpcRdo_handle.cptr(); 46 if ( not inputRDO ) { 47 ATH_MSG_FATAL("Unable to retrieve input RPC RDO container: " << m_keyRpcRdo.key()); 48 return StatusCode::FAILURE; 49 } 50 ATH_MSG_DEBUG("Number of RPC RDO: " << inputRDO->size()); 51 52 SG::ReadCondHandle cablingMap{m_cablingKey, ctx}; 53 ATH_CHECK(cablingMap.isValid()); 54 55 /// monitor RDO quantities 56 if ( !m_monTool.empty() ) { 57 58 auto n_of_RDO = Monitored::Scalar<unsigned int>("n_of_RDO",inputRDO->size()); -
This is not going to monitor anything. You are missing the
Monitored::Group. See https://atlassoftwaredocs.web.cern.ch/athena/trigger/monitoring/
54 55 /// monitor RDO quantities 56 if ( !m_monTool.empty() ) { 57 58 auto n_of_RDO = Monitored::Scalar<unsigned int>("n_of_RDO",inputRDO->size()); 59 60 } 61 62 63 /// output RoIs container 64 SG::WriteHandle<xAOD::MuonRoIContainer> outputRoI_handle(m_outputMuonRoIKey, ctx); 65 ATH_CHECK(outputRoI_handle.record(std::make_unique<xAOD::MuonRoIContainer>(), std::make_unique<xAOD::MuonRoIAuxContainer>())); 66 auto outputRoIs = outputRoI_handle.ptr(); 67 68 /// Create an RoI 69 outputRoIs->push_back(std::make_unique<xAOD::MuonRoI>()); 51 52 SG::ReadCondHandle cablingMap{m_cablingKey, ctx}; 53 ATH_CHECK(cablingMap.isValid()); 54 55 /// monitor RDO quantities 56 if ( !m_monTool.empty() ) { 57 58 auto n_of_RDO = Monitored::Scalar<unsigned int>("n_of_RDO",inputRDO->size()); 59 60 } 61 62 63 /// output RoIs container 64 SG::WriteHandle<xAOD::MuonRoIContainer> outputRoI_handle(m_outputMuonRoIKey, ctx); 65 ATH_CHECK(outputRoI_handle.record(std::make_unique<xAOD::MuonRoIContainer>(), std::make_unique<xAOD::MuonRoIAuxContainer>())); 66 auto outputRoIs = outputRoI_handle.ptr();
