IdDIctField - Update get_range

Instead of blindly trying to convert the parsed string to an integer, check before-hand whether the string contains digits.

Tagging: @sroe

ATLITKSW-297

added full-unit-tests label

This merge request affects 1 package:

• DetectorDescription/IdDict

This merge request affects 1 file:

• DetectorDescription/IdDict/src/IdDictField.cxx

Adding @apsallid ,@jojungge ,@rbianchi as watchers

added Geometry main review-pending-level-1 labels

changed title from IdDictDescrCnv - Update get_range to IdDIctField - Update get_range

removed Geometry main review-pending-level-1 labels

added Geometry main review-pending-level-1 labels

CI Result FAILURE (hash f5fb63e5)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Jenkins please retry a build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• DetectorDescription/IdDict

This merge request affects 1 file:

• DetectorDescription/IdDict/src/IdDictField.cxx

Adding @apsallid ,@jojungge ,@rbianchi as watchers

@jojungge : Doesn't std::stoi throw anyway if there are no digits in the string (which is already trapped) ?

it does, but I'm trying to appease the god of the Identifier and that's creating a jungle of exception messages to click through in gdb ;)

CI Result SUCCESS (hash f5fb63e5)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

changed the description

removed review-pending-level-1 label

added review-approved label

mentioned in commit 313b09cb

merged