Skip to content
Snippets Groups Projects

Adding new python scripts to work with CREST database

Merged Adding new python scripts to work with CREST database
solodkov/athena:tilecal-for-25.0 into main
All threads resolved!
Merged Sanya Solodkov requested to merge solodkov/athena:tilecal-for-25.0 into main
All threads resolved!

new scripts to read calibration constants from CREST DB and to prepare JSON file for CREST

Merge request reports

Pipeline #10936586 passed

Stage: external

Pipeline passed for 57159d68 on solodkov:tilecal-for-25.0

Approval is optional

Merged by Tadej NovakTadej Novak 1 month ago (Mar 3, 2025 3:35pm UTC)

Merge details

  • Changes merged into main with 84004362 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    Hi @solodkov ! There's some warnings in the CI test. Could you please have a look? Thanks, L1 (Fábio).

  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added review-user-action-required label

    added review-user-action-required label

  • Sanya Solodkov added 1 commit

    added 1 commit

    Compare with previous version

  • Sanya Solodkov resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • TileCalorimeter/TileCalib/TileCalibBlobPython

    This merge request affects 3 files:

    • TileCalorimeter/TileCalib/TileCalibBlobPython/python/TileCalibCrest.py
    • TileCalorimeter/TileCalib/TileCalibBlobPython/share/CopyBlobFromCool.py
    • TileCalorimeter/TileCalib/TileCalibBlobPython/share/ReadCalibFromCrest.py

    Adding @solodkov ,@pavol ,@iouri ,@harkusha as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 57159d68)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann
  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    One small question, otherwise looks good. -l1

  • Lukas Kretschmann added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Sanya Solodkov resolved all threads

    resolved all threads

  • Sanya Solodkov added review-pending-level-1 label

    added review-pending-level-1 label

  • Sanya Solodkov removed review-user-action-required label

    removed review-user-action-required label

  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Changes are fine and CI succeeds, approving for L1. -L1

  • Lukas Kretschmann added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Tadej Novak merged

    merged

  • Tadej Novak mentioned in commit 84004362

    mentioned in commit 84004362

    • Please register or sign in to reply