Skip to content
Snippets Groups Projects

Add ID field for FPGATrackSim Clustering

Merged Haider Abidi requested to merge sabidi/athena:addClusterID into main
All threads resolved!

This MR adds two index to each clustered point such that the strip/pixel GHitz and Track EDM test vector generation have a indexed connection between the two.

@brosser @jahreda @imaznas , this MR changes the EDM, which probably means new wrappers? Let me know if there are other changes that are needed due to this.

Merge request reports

Pipeline #10937157 passed

Pipeline passed for 5d6d05e7 on sabidi:addClusterID

Approval is optional

Merged by Tadej NovakTadej Novak 1 month ago (Mar 3, 2025 3:34pm UTC)

Merge details

  • Changes merged into main with 8ce3bb6c (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just one comment, otherwise looks good. -L1

  • Haider Abidi added 1 commit

    added 1 commit

    Compare with previous version

  • Haider Abidi resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimMaps
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimObjects

    Affected files list will not be printed in this case

    Adding @nagano ,@sutt as watchers

  • :white_check_mark: CI Result SUCCESS (hash 5d6d05e7)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Changes are fine and CI succeeds, approving for L1. -L1

  • Tadej Novak mentioned in commit 8ce3bb6c

    mentioned in commit 8ce3bb6c

  • merged

  • Please register or sign in to reply
    Loading