Skip to content
Snippets Groups Projects

FPGA TrackSim: GenScan re-factoring

Merged FPGA TrackSim: GenScan re-factoring
lipeles/athena:lipeles_merge into main
All threads resolved!
Merged Elliot Lipeles requested to merge lipeles/athena:lipeles_merge into main
All threads resolved!

This is the next installment of the re-factoring of the GenScan code. Here the old BinningBase has been split into three classes: -- BinDescBase which describes the variables for the track parameters for the binning -- BinStep which describes each step of the binning (this generalized the old code where the steps were hardwires to "slice", "scan", and "row") -- BinTool which contains a list of BinStep to define the full binning

@brosser you might want to start looking at these

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 1 month ago (Mar 10, 2025 12:45pm UTC)

Merge details

  • Changes merged into main with 9160d475 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lukas Kretschmann
  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Looks good to me other than the two comments, asking L2 to take a second look. -l1

  • Lukas Kretschmann added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Elliot Lipeles added 1 commit

    added 1 commit

    Compare with previous version

  • Elliot Lipeles resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning

    This merge request affects 5 files:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinDesc.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinStep.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinTool.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinStep.cxx
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinTool.cxx
  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label

    added review-pending-level-1 label and removed review-pending-level-2 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8aa6b8e2)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    MR already reviewed by previous shifter, just adding the request of a second look of the L2 before approving. L1 (Fábio).

  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added review-pending-level-2 label

    added review-pending-level-2 label

  • Karolos Potamianos
  • Karolos Potamianos
    Karolos Potamianos @karolos ·
    Owner

    Looks good from L2 PoV. Just a minor comment about a comment.

    Karolos (L2)

  • Karolos Potamianos added review-user-action-required label

    added review-user-action-required label

  • Elliot Lipeles added 1 commit

    added 1 commit

    • 50c2a86d - removed stray commented code

    Compare with previous version

  • Elliot Lipeles resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning

    This merge request affects 5 files:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinDesc.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinStep.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinTool.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinStep.cxx
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinTool.cxx
  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

    added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 50c2a86d)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Fabio Lucio Lucio Alves
    Fabio Lucio Lucio Alves @falves ·
    Developer

    All threads resolved and CI passed. Approving from L1 side (Fábio).

  • Fabio Lucio Lucio Alves removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fabio Lucio Lucio Alves added review-approved label

    added review-approved label

  • Tadej Novak
  • Tadej Novak
  • Tadej Novak removed review-approved label

    removed review-approved label

  • Tadej Novak added review-user-action-required label

    added review-user-action-required label

  • Elliot Lipeles added 1 commit

    added 1 commit

    • 1f2d6999 - renamed FPGATrackSimBinDescBase to IFPGATrackSimBinDesc

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning

    This merge request affects 5 files:

    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinStep.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/FPGATrackSimBinTool.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/FPGATrackSimBinning/IFPGATrackSimBinDesc.h
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinStep.cxx
    • Trigger/EFTracking/FPGATrackSim/FPGATrackSimBinning/src/FPGATrackSimBinTool.cxx
  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1f2d6999)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Lukas Kretschmann resolved all threads

    resolved all threads

  • Lukas Kretschmann
    Lukas Kretschmann @lkretsch ·
    Developer

    Changes look fine and CI succeeds, approving for L1. -L1

  • Lukas Kretschmann added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit 9160d475

    mentioned in commit 9160d475

    • Please register or sign in to reply