Draft: JetCalibTools Generic4VecCorrection for MC2MC, AF3, and PtResidual correction (R22 consolidated recs)
A new JetETMiss JetCalibTools algorithm Generic4VecCorrection for applying 3 types of jet calibrations that will be used for R22 consolidated recommendations. These corrections don't yet exist, so no tests will yet run with this code, but they will be needed very soon (in a few weeks). These changes were discussed in detail at https://indico.cern.ch/event/1521710/ . Related to ATLJETMET-1923, ATLJETMET-1824.
A few notes for reviewers & experts:
- The metadata implementation has been tested in AnalysisBase, Athena, and AthAnalysis, however may rely on an existing AsgMetadataTool to already be loaded in CA. Feedback on the optimal implementation here is welcome.
- Two new json files are used for storing exceptions and remappings of different MC generators for the correction. I think it's optimial to keep these here in gitlab, similiar to what the JetTileCorrectionTool does, as they should be lightweight, allows us to always track the history, will never need to be updated in a rush, and avoids using the atlas-groupdata/dev/ space (with its warning).
Also want to make PMG aware (@ancuetog @sargyrop) that this utilizes parsing of the generatorInfo, such as Powheg(v.06-02)+Herwig7(v.7.2.3p2)+EvtGen(v.2.1.1)
, and it will be important to keep this convention always for consistency. If you have documentation outlining the conventions here (e.g. Herwig's 4th version field seems to be delineated by p
instead of .
), that would be very useful for us to have for reference. If no such standards are yet written down, I'd be interested in having them written down to ensure standards are kept through the future.
Tagging @fballi , @bhodkins , @stapiaar , @jojamies , @cyoung, @delsart