Skip to content
Snippets Groups Projects

introduce shift in as built model for the QL3 modules

Merged Patrick Scholer requested to merge pscholer/athena:sTgcAsBuiltShiftDiamond into 24.0
All threads resolved!

The origin of the local coordinate system in the sTGC QL3 modules is not at the center of the active area but at the cutout. This introduced a correlation between the scale and the offset parameters in the stgc internal alignment fit, therefore the origin was moved in the fit. This MR introduces this shift when applying the as-built parameters.

cc @itrigger

Merge request reports

Pipeline #10991607 passed

Pipeline passed for 16004789 on pscholer:sTgcAsBuiltShiftDiamond

Merged by Duc TaDuc Ta 3 weeks ago (Mar 10, 2025 2:54pm UTC)

Merge details

  • Changes merged into 24.0 with 05e4175c (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS (hash 6b852599)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Please resolve the open thread. -L1

  • added 1 commit

    • 16004789 - use station name string instead of index

    Compare with previous version

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonAlignment/MuonAlignmentData

    This merge request affects 1 file:

    • MuonSpectrometer/MuonAlignment/MuonAlignmentData/src/sTGCAsBuiltData2.cxx

    Adding @kluit ,@jojungge ,@apsallid ,@mvozak ,@stavrop ,@pscholer as watchers

  • Johannes Junggeburth resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 16004789)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Changes are fine and CI succeeds, approving for L1. -L1

  • Duc Ta mentioned in commit 05e4175c

    mentioned in commit 05e4175c

  • merged

  • Adam Edward Barton mentioned in merge request !78402 (merged)

    mentioned in merge request !78402 (merged)

  • Please register or sign in to reply
    Loading