Introduce CRC validation for the MM trigger L1A elink

Introduce CRC validation for the MM trigger L1A elink directly when decoding. This MR does not break compatibility or data format, in case of future reprocessing. It's more a data integrity flag available for online DQ, debugging or expert checks.

@rowang @sturdy

added 1 commit

• cd6088f9 - It has to be inline

Compare with previous version

added 1 commit

• f985ead9 - adapt test app as well

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

This merge request affects 5 files:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWDecodeHelper.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWTriggerMML1AElink.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerMML1AElink.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder_aux.h

Adding @pscholer ,@jojungge ,@stavrop ,@mvozak ,@kluit ,@apsallid as watchers

added 24.0 MuonSpectrometer Trigger review-pending-level-1 labels

CI Result FAILURE (hash f985ead9)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

changed the description

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

This merge request affects 5 files:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWDecodeHelper.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWTriggerMML1AElink.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerMML1AElink.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder.cxx
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/test/test_nsw_trigger_common_decoder_aux.h

Adding @pscholer ,@jojungge ,@stavrop ,@kluit ,@apsallid ,@mvozak as watchers

CI Result SUCCESS (hash f985ead9)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Changes are fine and CI succeeds, approving for L1. -L1

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit bd82f576

merged

mentioned in merge request !78402 (merged)