Skip to content
Snippets Groups Projects

Simplifying process of switching noise in Inner Detector.

Open Simplifying process of switching noise in Inner Detector.
bdixit/athena:testing_noise_sim_in_ITk into main
4 unresolved threads
Open Bhupesh Dixit requested to merge bdixit/athena:testing_noise_sim_in_ITk into main
4 unresolved threads

I have added two more flags DoStripDetetorNoise and DoPixelDetectorNoise this will allow to switch on the noise in the. two detectors independently. Also, this MR will eliminate the need for a checkout for running Strip noise which was switched off by default.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Simulation/Digitization/DigitizationConfig/python/DigitizationConfigFlags.py
44 44 flags.addFlag("Digitization.DigiSteeringConf", _checkDigiSteeringConf)
45 45 # Run Inner Detector noise simulation
46 46 flags.addFlag("Digitization.DoInnerDetectorNoise", lambda prevFlags: not prevFlags.Common.isOverlay)
47 # Run Pixel Detector noise simulation
48 flags.addFlag("Digitization.DoPixelDetectorNoise", False)
49 # Run Strip Detector noise simulation
50 flags.addFlag("Digitization.DoStripDetectorNoise", False)
  • Comment on lines +47 to +50
    Thomas Strebler
    Thomas Strebler @tstreble ·
    Developer

    ITk should be in the name. The name for pixel is misleading otherwise.

    Also, the interaction between the ID flag and those flags is not straightforward. Can we rather set the default for those flags as a lambda based on the ID flag and drop the OR in the digi configs?

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    The flags should also default to Digitization.DoInnerDetectorNoise with a lambda or add a separate Digitization.DoITkNoise.

  • Please register or sign in to reply
  • Lukas Kretschmann added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Tadej Novak
    Tadej Novak @tadej started a thread on the diff
    • InnerDetector/InDetDigitization/PixelDigitization/python/ITkPixelDigitizationConfig.py
    56 56 acc.merge(ITkPixelModuleConfigCondAlgCfg(flags))
    57 57 acc.merge(ITkPixelChargeCalibCondAlgCfg(flags))
    58 58 kwargs.setdefault("BarrelEC", 0)
    59 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise)
    59 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoPixelDetectorNoise)
    • Tadej Novak
      Tadej Novak @tadej ·
      Developer
      Suggested change
      59 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoPixelDetectorNoise)
      59 kwargs.setdefault("DoNoise", flags.Digitization.DoPixelDetectorNoise)
    • Please register or sign in to reply
  • Tadej Novak
    Tadej Novak @tadej started a thread on the diff
    • InnerDetector/InDetDigitization/PixelDigitization/python/ITkPixelDigitizationConfig.py
    72 72 acc.merge(ITkPixelModuleConfigCondAlgCfg(flags))
    73 73 acc.merge(ITkPixelChargeCalibCondAlgCfg(flags))
    74 74 kwargs.setdefault("BarrelEC", 2)
    75 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise)
    75 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoPixelDetectorNoise)
    • Tadej Novak
      Tadej Novak @tadej ·
      Developer
      Suggested change
      75 kwargs.setdefault("DoNoise", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoPixelDetectorNoise)
      75 kwargs.setdefault("DoNoise", flags.Digitization.DoPixelDetectorNoise)
    • Please register or sign in to reply
  • Tadej Novak
    Tadej Novak @tadej started a thread on the diff
    • InnerDetector/InDetDigitization/StripDigitization/python/StripDigitizationConfig.py
    203 203 log = logging.getLogger("ITkStripFrontEndCfg")
    204 204 log.info("ITkStripDigitization:::: Turned off Noise in ITkStripFrontEnd")
    205 205 log.info("ITkStripDigitization:::: Overriding Digitization.DoInnerDetectorNoise flag")
    206 kwargs.setdefault("NoiseOn", False)
    207 kwargs.setdefault("AnalogueNoiseOn", False)
    206 kwargs.setdefault("NoiseOn", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoStripDetectorNoise)
    207 kwargs.setdefault("AnalogueNoiseOn", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoStripDetectorNoise)
    • Comment on lines +206 to +207
      Tadej Novak
      Tadej Novak @tadej ·
      Developer
      Suggested change
      207 kwargs.setdefault("AnalogueNoiseOn", flags.Digitization.DoInnerDetectorNoise or flags.Digitization.DoStripDetectorNoise)
      207 kwargs.setdefault("NoiseOn", flags.Digitization.DoStripDetectorNoise)
      208 kwargs.setdefault("AnalogueNoiseOn", flags.Digitization.DoStripDetectorNoise)
    • Please register or sign in to reply
  • Thomas Strebler
    Thomas Strebler @tstreble ·
    Developer

    @bdixit this is a kind reminder this MR is expecting some action from your side

    Best, Thomas - RC

    • Please register or sign in to reply