Draft: Add NNJvt variables to Trigger EDM

Store the NNJvt variables for detailed studies.

The input variable list would be fine for AODFULL only -- if we even decide to keep it long term.

The bare discriminant value + pass bit should be kept.

Can potentially remove some legacy JVT inputs as well.

Attn @cantel, @dwilson

marked this merge request as ready

This merge request affects 1 package:

• Trigger/TriggerCommon/TrigEDMConfig

This merge request affects 1 file:

• Trigger/TriggerCommon/TrigEDMConfig/python/TriggerEDMRun3.py

Adding @bernius ,@sutt ,@okuprash ,@cantel as watchers

added 24.0 Trigger TriggerEDM review-pending-level-1 labels

added 1 commit

• 3583a532 - Fix syntax removing detailed NNJvt vars from AODSLIM

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TrigEDMConfig

This merge request affects 1 file:

• Trigger/TriggerCommon/TrigEDMConfig/python/TriggerEDMRun3.py

Adding @cantel ,@bernius ,@okuprash ,@sutt as watchers

added 1 commit

• 02b7ac3d - Remove forgotten placeholder

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TrigEDMConfig

This merge request affects 1 file:

• Trigger/TriggerCommon/TrigEDMConfig/python/TriggerEDMRun3.py

Adding @sutt ,@cantel ,@bernius ,@okuprash as watchers

I don't know whether in this MR or in a follow up MR, but we might like to add the new NNJvtvariables for DAOD_JETM1 as well, in JetTriggerContentRun3.py - probably in a follow up MR to main as this file has diverged (of course it has).

CI Result FAILURE (hash b29f1e6d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 3583a532)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 02b7ac3d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)

added review-user-action-required label and removed review-pending-level-1 label

Do we want to add the NNJVT variables to TLA jets as well, or not yet?

added 13177 commits

• 02b7ac3d...7787c3b4 - 8 commits from branch atlas:24.0
• 7787c3b4...1f25f7fd - 13159 earlier commits
• 4696b5bf - Merge branch 'main-coverity-FPGATrackSimHough' into 'main'
• 3ddd7b44 - not reorder json key in BTagging tools
• 4cb70cd2 - Merge branch 'bdong-main-patch-c1e5' into 'main'
• b975a577 - add columnar container definitions for remaining containers
• 09fc8e71 - Merge branch 'container_def' into 'main'
• 1e640e9e - Add NNJvt variables to Trigger EDM
• 2bece89e - Fix syntax removing detailed NNJvt vars from AODSLIM
• 7f6b64e1 - Remove forgotten placeholder
• 7356254c - Syntax fix
• eb31af00 - Add NNJvt vars to TLA jets

Compare with previous version

marked this merge request as draft from khoo/athena@044c5297

resolved all threads

marked this merge request as ready

marked this merge request as draft

This merge request affects 55 packages:

• .devcontainer
• .vscode
• AsgExternal/Asg_Test
• AtlasGeometryCommon/BeamPipeGeoModel
• AtlasGeometryCommon/CavernInfraGeoModel
• AtlasGeometryCommon/CrackRegionGeoModel
• AtlasGeometryCommon/GeoModelEnvelopes
• AtlasGeometryCommon/SubDetectorEnvelopes
• AtlasTest/CITest
• AtlasTest/ControlTest
• AtlasTest/DatabaseTest/AthenaDBTestRec
• AtlasTest/DatabaseTest/AthenaPoolTest
• AtlasTest/DatabaseTest/AthenaPoolTestData
• AtlasTest/DatabaseTest/IOVDbTestAlg
• AtlasTest/DatabaseTest/IOVDbTestConditions
• AtlasTest/GoogleTestTools
• AtlasTest/TestTools
• Build
• Calorimeter/CaloCalibHitRec
• Calorimeter/CaloClusterCorrection
• Calorimeter/CaloCnv/CaloAthenaPool
• Calorimeter/CaloCnv/CaloCondAthenaPool
• Calorimeter/CaloCnv/CaloIdCnv
• Calorimeter/CaloCnv/CaloJiveXML
• Calorimeter/CaloCnv/CaloSimEventAthenaPool
• Calorimeter/CaloCnv/CaloSimEventTPCnv
• Calorimeter/CaloCnv/CaloTPCnv
• Calorimeter/CaloCnv/CaloTTDetDescrCnv
• Calorimeter/CaloCondBlobObjs
• Calorimeter/CaloCondPhysAlgs
• Calorimeter/CaloConditions
• Calorimeter/CaloDetDescr
• Calorimeter/CaloDetDescrUtils
• Calorimeter/CaloDmDetDescr
• Calorimeter/CaloEvent
• Calorimeter/CaloG4Sim
• Calorimeter/CaloGeoHelpers
• Calorimeter/CaloIdentifier
• Calorimeter/CaloInterface
• Calorimeter/CaloLocalHadCalib
• Calorimeter/CaloMonitoring
• Calorimeter/CaloRec
• Calorimeter/CaloRecGPU
• Calorimeter/CaloSimEvent
• Calorimeter/CaloTools
• Calorimeter/CaloTrackingGeometry
• Calorimeter/CaloTriggerTool
• Calorimeter/CaloUtils
• Commission/CommissionEvent
• Commission/CommissionRec
• Control/AthAllocators
• Control/AthAnalysisBaseComps
• Control/AthCUDA/AthCUDACore
• Control/AthCUDA/AthCUDAServices
• Control/AthContainers

Affected files list will not be printed in this case

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmt/TestFileLiteR3MCFastSim.txt
• .gitignore
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCFastSim.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteR3Data.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileR3Data.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MCFastSim.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileMCFastSim.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt

Adding @tkharlam ,@fwinkl ,@rbianchi ,@dossantn ,@akraszna ,@tadej ,@ahaas ,@pagessin ,@ssnyder ,@pavol ,@jchapman ,@fpastore ,@gemmeren as watchers

added Build CUDA Calorimeter Core DQ Geometry Other Overlay Simulation Test analysis-review-required review-pending-level-1 labels and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

368K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/ReadRDODoubleSelector.ref

116K in file Control/AthContainers/AthContainers/DataVector.h

236K in file Calorimeter/CaloCnv/CaloTPCnv/share/CaloCompactCellTool_test.ref

164K in file AtlasTest/DatabaseTest/IOVDbTestAlg/share/IOVDbTestReadCoolFromMD.ref

120K in file Control/AthContainers/AthContainers/DataVector.icc

added 9 commits

• eb31af00...ee98bd0d - 6 commits from branch atlas:24.0
• 37c75de9 - Add NNJvt variables to Trigger EDM
• 51eec96d - Fix syntax removing detailed NNJvt vars from AODSLIM
• 0b64cffb - Add NNJvt vars to TLA jets

Compare with previous version

Bad rebase messed up labels & watchers, will reopen to keep it clean.

closed

mentioned in merge request !78601 (merged)

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake	N/A	N/A	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A	N/A	N/A
tests	N/A	N/A	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)